-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] IOS - Empty screen seen when navigating back from workspace description the second time #53589
Comments
Triggered auto assignment to @muttmuure ( |
Job added to Upwork: https://www.upwork.com/jobs/~021865096772528155887 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 ( |
ProposalPlease re-state the problem that we are trying to solve in this issueEmpty screen gets shown and the workspace profile settings page animation is wrong, it slides from right to left after the empty screen has been shown first. What is the root cause of that problem?TLDR: The same RCA detailed in my proposal of this other issue. Note This issue is only present on narrow layout devices (native / mWeb) where screens displayed in RHP act as a modal. App/src/pages/workspace/WorkspaceInitialPage.tsx Lines 360 to 376 in 3baf965
When we open the workspace's initial page, the active route becomes We actually have the logic to only run it once here, but when we open the search page, all routes are "hidden" as explained here. Because of this, the Credits to bernhardoj for the RCA. What changes do you think we should make in order to solve the problem?We had a similar issue which I reviewed recently here where we navigated away from Same as proposed in the other issue, a practical solution for this kind of problem is to simply replace the way we navigate away from WS to the report here:
to use onPress={() => Navigation.dismissModal(currentUserPolicyExpenseChat?.reportID ?? '-1')} Why dismissing the modal first fixes our issue ? Important I proposed the same solution for this issue and because this solution would fix both issues, if my solution is selected on any of the two issues -> we should put the other one on HOLD. Result video (before / after)iOS: Native
|
@muttmuure, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
i'll try to priortize the review today 🙇 |
@ikevin127 Will this issue be fixed in #53600, i see we got a proposal selected there? |
cc @bernhardoj for input on this question |
No |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
will review over weekend 🙏 |
I tried your solution @ikevin127 It does solve the blank screen issue but when navigating back from report it goes to workspace list page instead of workspace settings since we dismissed Mosal. while its indeed better than the current behaviour i dont think its the ideal behaviour Screen.Recording.2024-12-17.at.12.15.02.AM.mov |
Expected result states:
From you video it looks like that the expected result is fulfilled with the proposed solution since the expected result did not specify what page we should land on. But ok, I'll look into this and try to come up with an alternative solution that would fulfill your expectations 👍 |
@muttmuure @ishpaul777 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
awaiting proposals |
I performed a ios.mp4 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
i am no longer able to reproduce the but having workspace profile page in background feels odd, Screen.Recording.2024-12-24.at.12.07.38.AM.mov@Expensify/design @muttmuure any thoughts on this? i think the desired behaviour is that if press back '<' from description user should land on report page not to workspace profile page.. |
I think the video looks correct? It seems to be navigating sequentially based on the browsing history. |
it seems it first navigates to workspace profile page then navigate to description which seems little odd to me, is the extra screen in between necessary? if that seems ok i think we can close this one, since issue in OP not reproducable anymore |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): nathanmulugetatesting+2338@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Empty screen does not get shown
Actual Result:
Empty screen gets shown and the workspace profile settings page animation is wrong, it slides from right to left after the empty screen has been shown first
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6684551_1733335793079.ScreenRecording_12-04-2024_21-02-36_1.1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ishpaul777The text was updated successfully, but these errors were encountered: