[HOLD for payment 2025-02-06] [HOLD for payment 2024-12-20] [HOLD for payment 2024-12-19] [$250] Updating report action button in the case of held expenses

[JmillsExpensify]

Based on this internal Slack discussion, we've decided that the approve button should be grey when all expenses on a report are held. This new feature makes sense for a couple of reasons:

• We already use this grey button pattern for Submit when a workspace has automatic scheduled submit settings
• When all expenses on a report a held, then the report is not GBRed for the admin, and as a result there is no required action on their part.
• Conversely, when a report has a mix of held and non-held expenses, we do show GBR for the admin because they can (and probably should) action on the expenses that can be actioned on.

As a result, let's do the following:

1. In the report thread, let's make the Approve or Pay buttons grey when all expenses on that report are held. Here's an example.
   

2. On the Search page, let's do the exact same thing, should a user end up seeing/finding this reports there instead.
   

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857475710560245957
• Upwork Job ID: 1857475710560245957
• Last Price Increase: 2024-11-15
• Automatic offers:
• NJ-2020 | Contributor | 105028413

Issue Owner

Current Issue Owner: @JmillsExpensify

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[JmillsExpensify]

Jon - please correct anything you don't agree with or would like to tweak in the OP. Once we're good, then I'll open up this issue to the community. Or @luacmartins let me know if this is better to take internal.

[daledah]

Edited by proposal-police: This proposal was edited at 2024-11-14 14:51:31 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

1. Create the new util function named areAllTransactionsOnHold, it's use isOnHold inside
2. In ReportPreview create the new variable:

const shouldDisablePayment = areAllTransactionsOnHold(transactions)

3. Pass shouldDisablePayment to AnimatedSettlementButton and SettlementButton
4. In SettlementButton, use shouldDisablePayment to disable all options in paymentButtonOptions and isDisabled

Do the same in MoneyReportHeader and other places

What alternative solutions did you explore? (Optional)

[github-actions]

[@username] Your proposal will be dismissed because you did not follow the proposal template.

[luacmartins]

I think this can be external

[dubielzyk-expensify]

Feels right to me. Just minor update to making sure the search icon is still there and the system message is correct: