[$250] Netsuite - App navigates to the first flow when refreshing the page while adding custom list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.42-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+shsb22tet1122@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to new dot with any account
2. Create a new workspace > Enable "Accounting" in the "More features" page
3. Navigate to "Accounting" > Connect to NetSuite and upgrade the workspace to Control > Enter credentials and finish
4. After the connection syncs go to Import > Custom Lists > Add custom list
5. Click on "Name" and select any of the options > Next > Type any ID name > Next
6. Before making any selection refresh the page

Expected Result:

App stays in the current flow ("How should this custom list be displayed in Expensify?")

Actual Result:

App navigates to the first step of the flow ("Choose a custom list" step)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6620920_1727773245095.2024-10-01_11_43_59.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021842185001478860112
• Upwork Job ID: 1842185001478860112
• Last Price Increase: 2024-10-11
• Automatic offers:
• rayane-djouah | Reviewer | 104455519
• allgandalf | Contributor | 104455521

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021842185001478860112

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Form navigates to first step on refresh

What is the root cause of that problem?

There are actually 2 bug in the flow:

• We do not save the current step anywhere in the flow.
  And we always default to the first step of the flow, that is why on refresh we go to the first step:

App/src/pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteImportAddCustomListPage.tsx

Line 155 in 99f280b

startStepIndex={CONST.NETSUITE_CUSTOM_FIELD_SUBSTEP_INDEXES.CUSTOM_LISTS.CUSTOM_LIST_PICKER}

• We also do not save the draft values in the flow.

So even if we fix 1, there would be a regression that values won't be saved once refreshed. So we need to fix both the bugs here.

What changes do you think we should make in order to solve the problem?

Like the refactor we did in :

• Refactor on missing details flow #49452

We need to refactor the full form to save draft values of the form as well as save the current state of the form (sub-step) using the util getInitialSubstep. We would also need to refactor NetSuiteImportAddCustomSegmentPage as both use the same substeps. and also update any similar places where this bug exists

Note

The scope of work is vast as this would be full form refactor i.e. adding draft states to Onyx, adding draft values to FORM input of both NetSuiteImportAddCustomSegmentPage and NetSuiteImportAddCustomListPage, creating new utils, changing the form structure completely, creating related types files.
So i think that for this issue a fair compensation would be $750 considering the amount of work involved

What alternative solutions did you explore? (Optional)

[melvin-bot]

@sonialiap, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rayane-djouah]

@allgandalf's proposal looks good to me

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[allgandalf]

thanks @rayane-djouah , @danieldoglas please take a look at the note, i have explained the scope of work and requested an increase in bounty, please consider that request 😄

[rayane-djouah]

I agree that a payment increase would be fair given the scope of work

[allgandalf]

bump @danieldoglas for assignment

[danieldoglas]

I missed this issue, my bad. I've read the proposal and I initially agree with it, but I'll refer to @yuwenmemon since he was one of the people working on this functionality before moving on.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rayane-djouah]

@yuwenmemon Kind reminder

[allgandalf]

I checked their slack, they are out of office until tuesday, @danieldoglas how should we proceed here?

[danieldoglas]

I think it's fine to wait for an answer in this case, I prefer not to change it without consulting the person who built it first.

[rayane-djouah]

Not overdue

[melvin-bot]

@danieldoglas @sonialiap @rayane-djouah this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[rayane-djouah]

Waiting on @yuwenmemon review

[sonialiap]

@yuwenmemon was OOO end of last week and this monday but hopefully will have time to review the proposal this week

[yuwenmemon]

Yep, @allgandalf's proposal looks good.

From the design doc:

Similar to how these fields function in the token auth setup, each field will be sticky in the sense that if the admin left Expensify and came back, everything would stay present. And, it’s important to keep these fields sticky such that admins can edit them.

So yes, draft values should be getting saved. cc @mananjadhav

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allgandalf]

@sonialiap can you bump the price for this issue please 🙏

[mananjadhav]

Thanks for picking this folks. I missed this one from the design doc. Let me know if any other help/secondary review is needed.

[allgandalf]

@rayane-djouah PR ready for review, there might be some style changes which i am working on currently , but you can test the functionality it works smooth

[allgandalf]

@rayane-djouah fixed the style changes as well, PR should be ready for final review

[rayane-djouah]

PR on staging