-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorWeeklyKSv2KSv2
Description
Problem
Currently, hot-reloading for web isn't functioning, causing prolonged waiting periods for developers during modifications. This wastes so much time during development.
Solution
I investigated the problem and found several issues with our current setup, here is a PR with the PoC
The key improvement is the ✨ state preservation ✨, since developers won't lose their current components state with each hot-reload.
Also I'm going to reach out to react-compiler team as I experience a crash when compiler is turned on and I try to refresh a component:

Before
hmr-not-working.mov
After
hmr.mov
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021854176886348335774
- Upwork Job ID: 1854176886348335774
- Last Price Increase: 2024-11-06
Issue Owner
Current Issue Owner: @joekaufmanexpensifyMetadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorWeeklyKSv2KSv2