Category-Saving GL & payroll code directed to category list instead of specific category

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.20
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4856835
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap profile icon -- workspaces-- workspace
3. Tap more features -- enable report field
4. Tap category
5. Tap on a category
6. Rename the category android save it
7. Note user directed to specfic category page
8. Enter GL code & payroll code and save it
9. Note user directed to category list instead of specific category page
10. Edit GL code & payroll code and save it
11. Note user directed to category list instead of specific category page

Expected Result:

Saving GL & payroll code must be directed to specific category page.

Actual Result:

Saving GL & payroll code directed to category list instead of specific category page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6571828_1723625332057.xh.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #vip-vsb

[BhuvaneshPatil]

PR which added these changes - #46617

Proposal

Please re-state the problem that we are trying to solve in this issue.

Upon saving GL and payroll code, we are directed to category list instead of specific category page

What is the root cause of that problem?

We are using dismissModal()

App/src/pages/workspace/categories/CategoryGLCodePage.tsx

Lines 35 to 44 in 29fb6bb

	const editGLCode = useCallback(
	(values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_CATEGORY_FORM>) => {
	const newGLCode = values.glCode.trim();
	if (newGLCode !== glCode) {
	Category.setPolicyCategoryGLCode(route.params.policyID, categoryName, newGLCode);
	}
	Navigation.dismissModal();
	},
	[categoryName, glCode, route.params.policyID],
	);

App/src/pages/workspace/categories/CategoryPayrollCodePage.tsx

Lines 35 to 44 in 29fb6bb

	const editPayrollCode = useCallback(
	(values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_CATEGORY_FORM>) => {
	const newPayrollCode = values.payrollCode.trim();
	if (newPayrollCode !== payrollCode) {
	Category.setPolicyCategoryPayrollCode(route.params.policyID, categoryName, newPayrollCode);
	}
	Navigation.dismissModal();
	},
	[categoryName, payrollCode, route.params.policyID],
	);

What changes do you think we should make in order to solve the problem?

We should use goBack() with appropriate fallback route.

With using fallback route to particular category, even when user refreshes it will redirect to correct page.

Navigation.goBack(ROUTES.WORKSPACE_CATEGORY_SETTINGS.getRoute(policyId, categoryName));

Screen.Recording.2024-08-14.at.4.35.02.PM.mov

Screen.Recording.2024-08-14.at.4.39.49.PM.mov

What alternative solutions did you explore? (Optional)

[BhuvaneshPatil]

@allroundexperts In PR it was converted from goBack() to dismissModal(). We can consider for upgrade pages but places pages where we change values. I am not getting that. Can you please explain. Thanks