[HOLD for payment 2024-11-05] Update Invoices setting screen

[madmax330]

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977
Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.sidhyk9taftq
Project: https://github.com/orgs/Expensify/projects/114/views/3

Feature Description

Manual Test Steps

Automated Tests

[danielrvidal]

I think this is just waiting for payment, right @madmax330 ?

[madmax330]

Yeah we need to pay the c+ for their review

[cretadn22]

@madmax330
@danielrvidal

I am working on #48345 and need to remove ROUTES.WORKSPACE_INVOICES

But I see a note:

App/src/pages/home/report/ReportActionItemMessage.tsx

Line 136 in 812fc31

// TODO: Uncomment the following line when the invoices screen is ready - https://github.com/Expensify/App/issues/45175.

Should we remove this comment?

[madmax330]

cc @VickyStash I don't think we want to remove it right?

[VickyStash]

Yeah, ROUTES.WORKSPACE_INVOICES route will be reused in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[rezkiy37]

@madmax330 @VickyStash should we close this issue?

[VickyStash]

@rezkiy37 I think we still need to align Invoice settings screen with the mockup.

We need to:

• Remove outdated sections
• Make Invoicing details section be visible
• Update the heading

After that we can close the issue.

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[rezkiy37]

Actively working on the issue.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update Invoices setting screen #50565

If no regressions arise, payment will be issued on 2024-11-05. 🎊

[fedirjh]

@madmax330 Could you please assign me, was C+ on #50565.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @greg-schroeder you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @fedirjh owed $250 via NewDot

BugZero Checklist (@greg-schroeder)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[greg-schroeder]

Payment summary:

C+: @fedirjh - $250 - You can make a manual request

[melvin-bot]

@madmax330 @greg-schroeder Be sure to fill out the Contact List!