[HOLD for payment 2023-09-04] [mWeb Safari] Date is trimmed on small devices when creating manual requetst

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Coming from #25449 (review)

Device: iPhone SE 3rd gen.

Steps:

1. Create a manual request
2. Set the date as 2023-08-01

Expected: 2023-08-01 is visible on confirm money request page
Actual: 2023-08-... is shown on confirm money request page

Screen.Recording.2023-08-19.at.02.39.57.mov

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @rushatgabhane
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BeeMargarida]

Hi, I'm Ana from Callstack - expert contributor group - I would like to work on this issue

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Date is trimmed on small devices (e.g. iPhone SE 3rd gen) when requesting money manually.

What is the root cause of that problem?

flexShrink1 in titleTextStyle is causing the date to get truncated.

App/src/components/MenuItem.js

Line 85 in 03cf0b1

styles.flexShrink1,

What changes do you think we should make in order to solve the problem?

Solution 1
Change the flexShrink1 style to flex1.

Solution 2
Considering that Solution 1 may lead to a regression (I need to do more testing for this to be sure), we can instead add a prop to MenuItem to conditionally override the style, and set this prop specifically for the Date field display.

What alternative solutions did you explore? (Optional)

None.

[BeeMargarida]

@rushatgabhane @mountiny I can't seem to replicate this, it seems fixed. Can you replicate? (I've used both @mountiny branch and the main branch)

iPhone SE 3rd generation	devTools to simulate a Galaxy S5
ios_d_t.mp4	browser_d_t.mp4

[akinwale]

@BeeMargarida It's reproducible in the iOS 16.2 simulator.

[mountiny]

@BeeMargarida Can you test on the PR where @rushatgabhane found it too? Its in the Create money request flow

[mountiny]

Oh Ok I see you have done that

[BeeMargarida]

I checked now in iOS 16.2 simulator, as @akinwale mentioned, I can reproduce. It's one of those bugs 🙃

[mountiny]

I am curious tho whats the root cause then? Probably dont have to spend much time on this, is the styling change @akinwale suggested enough and wont it introduce other regressions?

[BeeMargarida]

It might have been changes to WebKit in Safari 16.4. I checked the changelog, there are some mentions to overflow and flex, but no direct mention of this issue. Found a similar issue in StackOverflow.
I think @akinwale solution works, although I would suggest leaving the flexShrink1 instead of removing and instead add flex1 or w100 to the titleTextStyle in MenuItem. It seems like it has no side-effects in other places where MenuItem is used.

[mountiny]

@BeeMargarida would you be able to raise a PR with these changes please?

[BeeMargarida]

Yap, on it!

[BeeMargarida]

It's perhaps better to apply the flex on the MoneyRequestConfirmationList usage of MenuItem since it seems like this was previously fixed in some other places like this: #21404. I'll open a PR and we can discuss this there

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• #25561: apply flex1 to MenuItems titleStyle in MoneyRequestConfirmationList #25593

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @BeeMargarida does not require payment (Contractor)
• @rushatgabhane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@BeeMargarida] Determine if we should create a regression test for this bug.
• [@BeeMargarida] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[isabelastisser]

Payment summary:

• Issue reported by @rushatgabhane. $250 (Eligible for Manual Requests)
• @BeeMargarida does not require payment (Contractor)
• @akinwale accepted proposal, $1000, urgency bonus: $500.

@mountiny and @BeeMargarida Please complete the checklist so I can close the issue. Thanks!

[rushatgabhane]

Created a manual request - https://staging.new.expensify.com/r/6095912478187751

[akinwale]

Payment summary:

• Issue reported by @rushatgabhane. $250 (Eligible for Manual Requests)
• @BeeMargarida does not require payment (Contractor)
• @akinwale accepted proposal, $1000, urgency bonus: $500.

@mountiny and @BeeMargarida Please complete the checklist so I can close the issue. Thanks!

I did not submit a PR for this, and while I'm not opposed to the idea, I'm not sure if a bonus would be applicable here.

[mountiny]

@isabelastisser Lets do the classic 25% of the original price so $250 to @akinwale as his proposal was implemented internally

[isabelastisser]

Thanks for clarifying, @mountiny and @akinwale! The payment was made in Upwork; all set.

@mountiny and @BeeMargarida, Do you still need to complete the BZ checklist?

[mountiny]

No I think this is fine it was a new feature

[isabelastisser]

Thanks, we should be all set!

[JmillsExpensify]

$250 payment approved for @rushatgabhane based on BZ summary.