[HOLD for payment 2023-06-29] [$1000] Arrow key shortcut stops working

[aldo-expensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Coming from: https://github.com/Expensify/App/pull/18883/files#r1206010822

Action Performed:

1. Open the panel to invite new members to a workspace (/workspace//invite)
2. Verify that arrows up and down work and they change the selected row
3. Select something with the mouse
4. Click Next
5. Go back
6. BUG: The arrow keys don't change the highlighted row anymore

Expected Result:

Pressing UP or DOWN should change the highlighted row

Actual Result:

Pressing UP or DOWN doesn't do anything

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ecaf4548dae58200
• Upwork Job ID: 1668438254258597888
• Last Price Increase: 2023-06-13

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[aldo-expensify]

The cause is pretty narrowed down here:

• https://github.com/Expensify/App/pull/18883/files#r1206010822
• https://github.com/Expensify/App/pull/18883/files#r1205951089

I think this would have been easier to fix if we were dealing with functional components. There out of the box memoization with Class components. The recommended way is to use the library memoize-one which we don't currently have, and I'm not sure we want it since we are moving toward functional components.

[johncschuster]

FYI - No Slack thread for this one.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[flodnv]

From @aldo-expensify's investigation it seems like @roryabraham you caused this in #18883, can you have a look please and let us know what you think?