Add unit tests

Expensify · Nov 15, 2024 · fc97fdc · fc97fdc
1 parent fb4b456
commit fc97fdc
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 3 deletions.
diff --git a/src/libs/CardUtils.ts b/src/libs/CardUtils.ts
@@ -138,8 +138,8 @@ function maskCard(lastFour = ''): string {
  * @param bank - card bank.
  * @returns - The masked card string.
  */
-function maskCardNumber(cardName: string, bank: string): string {
-    if (!cardName || cardName === '' || bank === '') {
+function maskCardNumber(cardName: string, bank: string | undefined): string {
+    if (!cardName || cardName === '' || !bank) {
         return '';
     }
     const hasSpace = /\s/.test(cardName);

diff --git a/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx b/src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx
@@ -76,7 +76,7 @@ function ConfirmationStep({policyID, backTo}: ConfirmationStepProps) {
                 />
                 <MenuItemWithTopDescription
                     description={translate('workspace.companyCards.card')}
-                    title={CardUtils.maskCardNumber(data?.cardNumber ?? '', data?.bankName ?? '')}
+                    title={CardUtils.maskCardNumber(data?.cardNumber ?? '', data?.bankName)}
                     shouldShowRightIcon
                     onPress={() => editStep(CONST.COMPANY_CARD.STEP.CARD)}
                 />

diff --git a/tests/unit/CardUtilsTest.ts b/tests/unit/CardUtilsTest.ts
@@ -215,4 +215,41 @@ describe('CardUtils', () => {
             expect(feedName).toBe(undefined);
         });
     });
+
+    describe('maskCardNumber', () => {
+        it("Should return the card number divided into chunks of 4, with 'X' replaced by '•' if it's provided in the '480801XXXXXX2554' format", () => {
+            const cardNumber = '480801XXXXXX2554';
+            const maskedCardNumber = CardUtils.maskCardNumber(cardNumber, CONST.COMPANY_CARD.FEED_BANK_NAME.MASTER_CARD);
+            expect(maskedCardNumber).toBe('4808 01•• •••• 2554');
+        });
+
+        it("Should return card number without changes if it's provided in the 'CREDIT CARD...6607' format", () => {
+            const cardNumber = 'CREDIT CARD...6607';
+            const maskedCardNumber = CardUtils.maskCardNumber(cardNumber, CONST.COMPANY_CARD.FEED_BANK_NAME.CHASE);
+            expect(maskedCardNumber).toBe(cardNumber);
+        });
+
+        it("Should return the Amex direct feed card number divided into 4/6/5 chunks, with 'X' replaced by '•'", () => {
+            const cardNumber = '211944XXXXX6557';
+            const maskedCardNumber = CardUtils.maskCardNumber(cardNumber, CONST.COMPANY_CARD.FEED_BANK_NAME.AMEX_DIRECT);
+            expect(maskedCardNumber).toBe('2119 44•••• •6557');
+        });
+
+        it("Should return the Amex custom feed card number divided into 4/6/5 chunks, with 'X' replaced by '•'", () => {
+            const cardNumber = '211944XXXXX6557';
+            const maskedCardNumber = CardUtils.maskCardNumber(cardNumber, CONST.COMPANY_CARD.FEED_BANK_NAME.AMEX);
+            expect(maskedCardNumber).toBe('2119 44•••• •6557');
+        });
+
+        it('Should return empty string if undefined bank was provided', () => {
+            const cardNumber = '480801XXXXXX2554';
+            const maskedCardNumber = CardUtils.maskCardNumber(cardNumber, undefined);
+            expect(maskedCardNumber).toBe('');
+        });
+
+        it('Should return empty string if invalid card name was provided', () => {
+            const maskedCardNumber = CardUtils.maskCardNumber('', CONST.COMPANY_CARD.FEED_BANK_NAME.MASTER_CARD);
+            expect(maskedCardNumber).toBe('');
+        });
+    });
 });