Merge pull request #46888 from callstack-internal/details-metadata-in…

…-fb-trace

Add personalDetails and report length to fb trace metadata

jest/setup.ts

@@ -73,3 +73,8 @@ jest.mock('react-native-reanimated', () => ({
 }));
 
 jest.mock('react-native-keyboard-controller', () => require<typeof RNKeyboardController>('react-native-keyboard-controller/jest'));
+
+jest.mock('@src/libs/actions/Timing', () => ({
+    start: jest.fn(),
+    end: jest.fn(),
+}));

src/libs/Firebase/index.native.ts

@@ -2,8 +2,10 @@
 import crashlytics from '@react-native-firebase/crashlytics';
 import perf from '@react-native-firebase/perf';
 import * as Environment from '@libs/Environment/Environment';
+import * as PersonalDetailsUtils from '@libs/PersonalDetailsUtils';
+import * as ReportConnection from '@libs/ReportConnection';
 import * as SessionUtils from '@libs/SessionUtils';
-import type {Log, StartTrace, StopTrace, TraceMap} from './types';
+import type {FirebaseAttributes, Log, StartTrace, StopTrace, TraceMap} from './types';
 
 const traceMap: TraceMap = {};
 
@@ -17,12 +19,14 @@ const startTrace: StartTrace = (customEventName) => {
         return;
     }
 
-    const session = SessionUtils.getSession();
+    const attributes = getAttributes();
 
     perf()
         .startTrace(customEventName)
         .then((trace) => {
-            trace.putAttribute('accountID', session?.accountID?.toString() ?? 'N/A');
+            Object.entries(attributes).forEach(([name, value]) => {
+                trace.putAttribute(name, value);
+            });
             traceMap[customEventName] = {
                 trace,
                 start,
@@ -55,6 +59,20 @@ const log: Log = (action: string) => {
     crashlytics().log(action);
 };
 
+function getAttributes(): FirebaseAttributes {
+    const session = SessionUtils.getSession();
+
+    const accountId = session?.accountID?.toString() ?? 'N/A';
+    const reportsLength = ReportConnection.getAllReportsLength().toString();
+    const personalDetailsLength = PersonalDetailsUtils.getPersonalDetailsLength().toString();
+
+    return {
+        accountId,
+        reportsLength,
+        personalDetailsLength,
+    };
+}
+
 export default {
     startTrace,
     stopTrace,

src/libs/Firebase/types.ts

@@ -8,5 +8,10 @@ type TraceMap = Record<string, Trace>;
 type StartTrace = (customEventName: string) => void;
 type StopTrace = (customEventName: string) => void;
 type Log = (action: string) => void;
+type FirebaseAttributes = {
+    accountId: string;
+    personalDetailsLength: string;
+    reportsLength: string;
+};
 
-export type {StartTrace, StopTrace, TraceMap, Log};
+export type {StartTrace, StopTrace, TraceMap, Log, FirebaseAttributes};

src/libs/PersonalDetailsUtils.ts

@@ -323,6 +323,10 @@ function isPersonalDetailsEmpty() {
     return !personalDetails.length;
 }
 
+function getPersonalDetailsLength() {
+    return personalDetails.length;
+}
+
 export {
     isPersonalDetailsEmpty,
     getDisplayNameOrDefault,
@@ -339,4 +343,5 @@ export {
     createDisplayName,
     extractFirstAndLastNameFromAvailableDetails,
     getNewAccountIDsAndLogins,
+    getPersonalDetailsLength,
 };

src/libs/ReportConnection.ts

@@ -44,4 +44,8 @@ function getAllReportsNameMap() {
     return reportIDToNameMap;
 }
 
-export {getAllReports, getAllReportsNameMap};
+function getAllReportsLength() {
+    return Object.keys(allReports ?? {}).length;
+}
+
+export {getAllReports, getAllReportsNameMap, getAllReportsLength};

src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.tsx

@@ -31,7 +31,7 @@ function BaseSidebarScreen() {
 
     useEffect(() => {
         Performance.markStart(CONST.TIMING.SIDEBAR_LOADED);
-        Timing.start(CONST.TIMING.SIDEBAR_LOADED, true);
+        Timing.start(CONST.TIMING.SIDEBAR_LOADED);
     }, []);
 
     useEffect(() => {