Merge pull request #49826 from Expensify/Rory-FixTypes

[No QA] Fix types
Expensify · Sep 26, 2024 · a935a15 · a935a15
2 parents 70a8a16 + a5ff556
commit a935a15
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/src/languages/en.ts b/src/languages/en.ts
@@ -54,6 +54,7 @@ import type {
     DefaultVendorDescriptionParams,
     DelegateRoleParams,
     DelegateSubmitParams,
+    DelegatorParams,
     DeleteActionParams,
     DeleteConfirmationParams,
     DeleteExpenseTranslationParams,
@@ -4818,7 +4819,7 @@ const translations = {
             }
         },
         genericError: 'Oops, something went wrong. Please try again.',
-        onBehalfOfMessage: (delegator: string) => `on behalf of ${delegator}`,
+        onBehalfOfMessage: ({delegator}: DelegatorParams) => `on behalf of ${delegator}`,
         accessLevel: 'Access level',
         confirmCopilot: 'Confirm your copilot below.',
         accessLevelDescription: 'Choose an access level below. Both Full and Limited access allow copilots to view all conversations and expenses.',

diff --git a/src/languages/es.ts b/src/languages/es.ts
@@ -53,6 +53,7 @@ import type {
     DefaultVendorDescriptionParams,
     DelegateRoleParams,
     DelegateSubmitParams,
+    DelegatorParams,
     DeleteActionParams,
     DeleteConfirmationParams,
     DeleteExpenseTranslationParams,
@@ -5338,7 +5339,7 @@ const translations = {
             }
         },
         genericError: '¡Ups! Ha ocurrido un error. Por favor, inténtalo de nuevo.',
-        onBehalfOfMessage: (delegator: string) => `en nombre de ${delegator}`,
+        onBehalfOfMessage: ({delegator}: DelegatorParams) => `en nombre de ${delegator}`,
         accessLevel: 'Nivel de acceso',
         confirmCopilot: 'Confirma tu copiloto a continuación.',
         accessLevelDescription: 'Elige un nivel de acceso a continuación. Tanto el acceso Completo como el Limitado permiten a los copilotos ver todas las conversaciones y gastos.',

diff --git a/src/languages/params.ts b/src/languages/params.ts
@@ -469,6 +469,8 @@ type ReconciliationWorksParams = {lastFourPAN: string};
 
 type DelegateRoleParams = {role: DelegateRole};
 
+type DelegatorParams = {delegator: string};
+
 type RoleNamesParams = {role: string};
 
 type AssignCardParams = {
@@ -565,6 +567,7 @@ export type {
     AssignedYouCardParams,
     SpreadCategoriesParams,
     DelegateRoleParams,
+    DelegatorParams,
     ReconciliationWorksParams,
     LastSyncAccountingParams,
     SyncStageNameConnectionsParams,

diff --git a/src/pages/home/report/ReportActionItemSingle.tsx b/src/pages/home/report/ReportActionItemSingle.tsx
@@ -375,7 +375,7 @@ function ReportActionItemSingle({
                     </View>
                 ) : null}
                 {action?.delegateAccountID && !isReportPreviewAction && (
-                    <Text style={[styles.chatDelegateMessage]}>{translate('delegate.onBehalfOfMessage', accountOwnerDetails?.displayName ?? '')}</Text>
+                    <Text style={[styles.chatDelegateMessage]}>{translate('delegate.onBehalfOfMessage', {delegator: accountOwnerDetails?.displayName ?? ''})}</Text>
                 )}
                 <View style={hasBeenFlagged ? styles.blockquote : {}}>{children}</View>
             </View>