Skip to content

feat: graphql java 23 update #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

samuelAndalon
Copy link
Contributor

@samuelAndalon samuelAndalon commented Apr 29, 2025

📝 Description

https://github.com/graphql-java/graphql-java/releases/tag/v23.1
https://github.com/graphql-java/graphql-java/releases/tag/v23.0

graphql-java 22 introduced the support to @defer directive, however, it wasn't added to the SDL, now in graphql-java 23 @defer is being, added. For now, we will disable @defer because work will be needed to implement the transport of responses through HTTP.

graphql-java 23 broke the data loader dispatch by synchronous execution exhaustion mechanism, because of the introduction of dataLoader hooks, the reason is because the mechanism was relying on the number of dependents of the CompletableFuture returned by the dataLoader, which now is instrumented and adds extra dependents.

significant changes were done to stop relying on number of dependents and instead, use the instrumentation provided by the data loader library

A KotlinDataLoaderRegistry decorator is no longer needed, with this we will simply the execution.

@samuelAndalon samuelAndalon changed the title feat: graphql java 23 update (WIP) feat: graphql java 23 update Apr 29, 2025
@samuelAndalon samuelAndalon force-pushed the feat/graphql-java-23-update branch from 10407cd to a15a68a Compare April 30, 2025 22:00
@samuelAndalon samuelAndalon marked this pull request as ready for review April 30, 2025 22:06
Copy link

github-actions bot commented May 2, 2025

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@samuelAndalon samuelAndalon changed the title (WIP) feat: graphql java 23 update feat: graphql java 23 update May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants