-
Notifications
You must be signed in to change notification settings - Fork 360
feat: graphql java 23 update #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samuelAndalon
wants to merge
12
commits into
master
Choose a base branch
from
feat/graphql-java-23-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10407cd
to
a15a68a
Compare
Apollo Federation Subgraph Compatibility Results
Learn more: |
Samjin
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
https://github.com/graphql-java/graphql-java/releases/tag/v23.1
https://github.com/graphql-java/graphql-java/releases/tag/v23.0
graphql-java 22 introduced the support to
@defer
directive, however, it wasn't added to the SDL, now in graphql-java 23@defer
is being, added. For now, we will disable@defer
because work will be needed to implement the transport of responses through HTTP.graphql-java 23 broke the data loader dispatch by synchronous execution exhaustion mechanism, because of the introduction of dataLoader hooks, the reason is because the mechanism was relying on the number of dependents of the CompletableFuture returned by the dataLoader, which now is instrumented and adds extra dependents.
significant changes were done to stop relying on number of dependents and instead, use the instrumentation provided by the data loader library
A KotlinDataLoaderRegistry decorator is no longer needed, with this we will simply the execution.