feat: SingletonPropertyDataFetcher, avoid allocating a PropertyDataFetcher per property per graphql operation #2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tcher per property per graphql operation
samuelAndalon
requested review from
dariuszkuc,
markdstevens,
tapaderster and
Samjin
samuelAndalon
commented
Apr 10, 2025
...rver/src/main/kotlin/com/expediagroup/graphql/server/spring/GraphQLExecutionConfiguration.kt
Outdated
Show resolved
Hide resolved
|
are we missing documentation? |
tapaderster
approved these changes
Apr 11, 2025
richeyh
approved these changes
Apr 11, 2025
samuelAndalon
added a commit
that referenced
this pull request
Apr 14, 2025
…tcher per property per graphql operation (#2079) ### 📝 Description Inspired by graphql-java/graphql-java#3754. Currently, graphql-kotlin, through the [KotlinDataFetcherFactoryProvider](https://github.com/ExpediaGroup/graphql-kotlin/blob/master/generator/graphql-kotlin-schema-generator/src/main/kotlin/com/expediagroup/graphql/generator/execution/KotlinDataFetcherFactoryProvider.kt#L62) creates a [PropertyDataFetcher](https://github.com/ExpediaGroup/graphql-kotlin/blob/master/generator/graphql-kotlin-schema-generator/src/main/kotlin/com/expediagroup/graphql/generator/execution/PropertyDataFetcher.kt) per source's property. This instance is created [every single time ](https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/schema/GraphQLCodeRegistry.java#L100)the graphql-java [DataFetcherFactory](https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/schema/DataFetcherFactory.java) is invoked, which happens to be on runtime per property per graphql-operation. This PR will introduce a new object class `SingletonPropertyDataFetcher` which will host its own singleton factory that will always return `SingletonPropertyDataFetcher` which will store all `KProperty.Getter<*>`s in a ConcurrentHashMap. Instead of just replacing the SimpleKotlinDataFetcherFactoryProvider, I am creating a new one, to avoid breaking changes, and to allow users to decide what they want, this switch might come with a cost, we are avoiding object allocations, in favor of a singleton that will possibly hold thousands of `KProperty.Getter<*>`s. --------- Co-authored-by: Samuel Vazquez <samvazquez@expediagroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Inspired by graphql-java/graphql-java#3754.
Currently, graphql-kotlin, through the KotlinDataFetcherFactoryProvider creates a PropertyDataFetcher per source's property.
This instance is created every single time the graphql-java DataFetcherFactory is invoked, which happens to be on runtime per property per graphql-operation.
This PR will introduce a new object class
SingletonPropertyDataFetcherwhich will host its own singleton factory that will always returnSingletonPropertyDataFetcherwhich will store allKProperty.Getter<*>s in a ConcurrentHashMap.Instead of just replacing the SimpleKotlinDataFetcherFactoryProvider, I am creating a new one, to avoid breaking changes, and to allow users to decide what they want, this switch might come with a cost, we are avoiding object allocations, in favor of a singleton that will possibly hold thousands of
KProperty.Getter<*>s.