Skip to content

fix(federation): Federation errors should not return invalid locations #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2024
Merged

fix(federation): Federation errors should not return invalid locations #1990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42e6d2f
fix(federation): Federation errors should not return invalid locations
dariuszkuc Jun 27, 2024
86fc873
update dates
dariuszkuc Jun 27, 2024
2e61a37
lint
dariuszkuc Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...kotlin/com/expediagroup/graphql/generator/federation/exception/FederatedRequestFailure.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2019 Expedia, Inc
* Copyright 2024 Expedia, Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -29,7 +29,7 @@ class FederatedRequestFailure(private val errorMessage: String, private val erro

override fun getErrorType(): ErrorClassification = ErrorType.DataFetchingException

override fun getLocations(): List<SourceLocation> = listOf(SourceLocation(-1, -1))
override fun getLocations(): List<SourceLocation>? = null

override fun getExtensions(): Map<String, Any>? =
if (error != null) {
Expand Down
4 changes: 2 additions & 2 deletions ...kotlin/com/expediagroup/graphql/generator/federation/exception/InvalidFederatedRequest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2019 Expedia, Inc
* Copyright 2024 Expedia, Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -29,5 +29,5 @@ class InvalidFederatedRequest(private val errorMessage: String) : GraphQLError {

override fun getErrorType(): ErrorClassification = ErrorType.ValidationError

override fun getLocations(): List<SourceLocation> = listOf(SourceLocation(-1, -1))
override fun getLocations(): List<SourceLocation>? = null
}
5 changes: 2 additions & 3 deletions ...in/com/expediagroup/graphql/generator/federation/exception/FederatedRequestFailureTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2019 Expedia, Inc
* Copyright 2024 Expedia, Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -17,7 +17,6 @@
package com.expediagroup.graphql.generator.federation.exception

import graphql.ErrorType
import graphql.language.SourceLocation
import org.junit.jupiter.api.Test
import kotlin.test.assertEquals
import kotlin.test.assertNull
Expand All @@ -38,7 +37,7 @@ internal class FederatedRequestFailureTest {

@Test
fun getLocations() {
assertEquals(expected = listOf(SourceLocation(-1, -1)), actual = simpleFailure.locations)
assertNull(simpleFailure.locations)
}

@Test
Expand Down