Support creating the new context map #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrick
added
changes: minor
dariuszkuc
reviewed
Oct 27, 2021
...otlin-server/src/main/kotlin/com/expediagroup/graphql/server/extensions/requestExtensions.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
reviewed
Oct 27, 2021
...otlin-server/src/main/kotlin/com/expediagroup/graphql/server/extensions/requestExtensions.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
reviewed
Oct 27, 2021
...in-server/src/main/kotlin/com/expediagroup/graphql/server/execution/GraphQLContextFactory.kt
Show resolved
Hide resolved
|
Can you also update the docs |
dariuszkuc
reviewed
Oct 28, 2021
...otlin-server/src/main/kotlin/com/expediagroup/graphql/server/extensions/requestExtensions.kt
Outdated
Show resolved
Hide resolved
added 2 commits
October 28, 2021 09:41
smyrick
commented
Oct 28, 2021
| @@ -31,7 +30,7 @@ class RequestExtensionsKtTest { | |||
| val request = GraphQLRequest(query = "query { whatever }") | |||
| val executionInput = request.toExecutionInput() | |||
| assertEquals(request.query, executionInput.query) | |||
| assertNull(executionInput.context) | |||
There was a problem hiding this comment.
If it is not set, then graphql-java defaults to empty object. This is a much better validation regardless of the new map
smyrick
commented
Oct 28, 2021
...lin/com/expediagroup/graphql/server/spring/subscriptions/SpringGraphQLSubscriptionHandler.kt
Outdated
Show resolved
Hide resolved
dariuszkuc
approved these changes
Oct 28, 2021
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Support creating the new context map * Fix subscription hooks * Update docs and deprecation notice * Use inline builder * Update unit test docs * Use default context map in subscriptions test * Undo public arg name changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
GraphQL Java 17 introduced the new context map instead of one object. We need to be able to pass this in to the execution input for queries, mutations, and subscriptions for things like the
PreParsedDocumentProvideroptions🔗 Related Issues
Backwards compatible version of this PR: #1277