[plugin] support android compile targets #1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
added
changes: patch
dariuszkuc
force-pushed
the
android_build
branch
from
d5ef6b2 to
3efb6af
Compare
added 3 commits
July 27, 2021 12:53
Default (JVM) build use `compileKotlin`/`compileTestKotlin` tasks. Android builds use variants which has their own targets (e.g. `compileDebugKotlin`). Since our tasks are finalized by the compile tasks we cannot apply it on android builds as default JVM tasks dont exist.
Gradle scans all decorated plugin/tasks/extensions classes to find all the injection points, apply validations etc. This means that we cannot have any method signatures in the plugin code that references compile only dependencies. Simple fix is to move the affected code to a separate file. See: gradle/gradle#8411 for details.
dariuszkuc
force-pushed
the
android_build
branch
from
3efb6af to
095e36f
Compare
dariuszkuc
commented
Jul 28, 2021
|
|
||
| @ParameterizedTest | ||
| @MethodSource("pluginTests") | ||
| @EnabledIfEnvironmentVariable(named = "ANDROID_SDK_ROOT", matches = ".+") |
There was a problem hiding this comment.
While Github Actions runners come preconfigured with Android setup, this ensures it will only execute if ANDROID_SDK_ROOT is set (so devs not touching this code don't have to setup Android env).
smyrick
approved these changes
Jul 28, 2021
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* [plugin] support android compile targets Default (JVM) build use `compileKotlin`/`compileTestKotlin` tasks. Android builds use variants which has their own targets (e.g. `compileDebugKotlin`). Since our tasks are finalized by the compile tasks we cannot apply it on android builds as default JVM tasks dont exist. * fix compile dependency Gradle scans all decorated plugin/tasks/extensions classes to find all the injection points, apply validations etc. This means that we cannot have any method signatures in the plugin code that references compile only dependencies. Simple fix is to move the affected code to a separate file. See: gradle/gradle#8411 for details. * fix android build dependency * parameterize android plugin version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Default (JVM) build use
compileKotlin/compileTestKotlintasks. Android builds use variants which has their own targets (e.g.compileDebugKotlin). Since our tasks were finalized by the compile tasks we couldn't apply it on android builds as default JVM tasks don't exist.Cleaned up plugin logic for the default JVM builds by removing unnecessary
finalizeByclauses as adding client generating taskOutputDirectoryto the main/test sources automatically configures the necessary dependencies. Unfortunately same logic cannot be applied on Android projects as Android plugin is eagerly configured so configuring additional sources happens after this resolution. Until Android plugin is updated to support lazy configuration, we need to explicitly configure compile tasks to depend on our client generation tasks.🔗 Related Issues
Resolves: #1203