fix(approvals-satisfied): fix teams with over 100 members #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treyp
force-pushed
the
large-approval-teams
branch
from
f981c6e to
14da080
Compare
sayali10
reviewed
Feb 28, 2025
| import { convertToTeamSlug } from './convert-to-team-slug'; | ||
| import { context } from '@actions/github'; | ||
|
|
||
| export const paginateMembersInOrg = async (team: string, page: number = 1): Promise<MembersInOrg> => { |
There was a problem hiding this comment.
Something to look out for: If someone tried to fetch members of large github teams it might end up hitting API limit.
Contributor
There was a problem hiding this comment.
Looks like the max team size is 5000, in which case this would use 50 API hits which wouldn't reach any rate limit.
sayali10
approved these changes
Feb 28, 2025
treyp
force-pushed
the
large-approval-teams
branch
from
14da080 to
c540305
Compare
danadajian
approved these changes
Mar 1, 2025
|
🎉 This PR is included in version 1.74.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
approvals-satisfiedscript, when fetching the members for a GitHub team, only the first page of 100 members is fetched. This is a limitation for teams with more than 100 members. This PR adds support for fetching all pages of members of an org.🔗 Related Issues