fix(action): reduce false-positive stale flags and orphaned new-images in manifest workflows - #809
Merged
Conversation
…ffer from the merged changeset Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…during manifest-compare Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.46.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related refinements to the manifest workflows, both aimed at eliminating misleading review noise:
1. Skip flagging open PRs whose overlapping changeset values match the merged changeset.
manifest-mergeflags every open PR whose stored changeset overlaps the merged changeset on any screenshot path, failing its Visual Regression status with "please rebase". The overlap check compared paths only, so an open PR whose hash for a shared path is identical to the value that just merged — meaning it fully agrees with the new baseline and could not clobber it — was still flagged.2. Delete uploaded new-images that fall outside the final review set during manifest-compare.
manifest-generateuploads anew.pngfor every screenshot whose hash differs from the base branch's manifest at generate time, but compare may later exclude some of those paths from review — visually identical to their base image (hash noise from nondeterministic rendering), owned by main, or stale from a prior run. The leftover files stayed undernew-images/{sha}/, and since the Comparadise UI lists everything under that prefix, they appeared as spurious "new" screenshots with no base to compare against.Both changes come with tests, and the committed action bundle is rebuilt.
🤖 Generated with Claude Code