test value that might overflow

Expander · Oct 6, 2023 · 92a5771 · 92a5771
1 parent 8697110
commit 92a5771
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/Li2.jl b/src/Li2.jl
@@ -236,8 +236,6 @@ li2(z::Real) = li2(Complex(z))
 _li2(z::ComplexF16) = oftype(z, _li2(ComplexF32(z)))
 
 function _li2(z::Complex{T})::Complex{T} where T
-    clog(z) = T == Float64 ? complex(0.5*log(abs2(z)), angle(z)) : complex(log(abs(z)), angle(z))
-
     rz, iz = reim(z)
 
     if iszero(iz)

diff --git a/src/Log.jl b/src/Log.jl
@@ -2,7 +2,7 @@
 # handles case when imag(z) == -0.0
 function clog(z::Complex)
     ang = angle(z)
-    Complex(one(typeof(real(z)))/2*log(abs2(z)), imag(z) == zero(z.re) && ang < zero(z.re) ? -ang : ang)
+    Complex(log(abs(z)), iszero(imag(z)) && ang < zero(z.re) ? -ang : ang)
 end
 
 # returns logarithm of x

diff --git a/test/Li2.jl b/test/Li2.jl
@@ -38,4 +38,7 @@
 
     @test real(PolyLog.li2(-1.08371e-08 + 1.32716e-24*im)) == -1.0837099970639316e-08
     @test imag(PolyLog.li2(-1.08371e-08 + 1.32716e-24*im)) ==  1.3271599928087172e-24
+
+    # test value that causes overflow if squared
+    @test real(PolyLog.li2(1e300 + 1im)) ≈ real(-238582.12510339421 - 2170.13532372464im) rtol=eps(Float64)
 end