You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Review translation updates for quality and completeness
Provide feedback on the PR
Summary
This PR contains automated translation updates from Crowdin for the English translation file (en.po). The changes add English translations for 22 previously untranslated strings in the DPIP Flutter application.
Review Findings
✅ Positive Aspects
Translation Coverage: All 22 new translations fill in previously empty msgstr entries, improving the English localization coverage
File Integrity: The .po file structure is properly maintained with correct formatting
Metadata Update: The PO-Revision-Date is correctly updated to 2025-11-29 10:55
⚠️Translation Quality Issues
I've identified several translation quality concerns that should be addressed:
msgid"為了在背景持續提供即時防災資訊,DPIP 需要「永遠允許」位置權限。\n\n接下來系統會引導您到設定頁面,請選擇「永遠允許」選項。"msgstr"To continuing giving the disaster prevention information immediately, DPIP needs the access of location forever.\n\nSystem will guide you to the setting, please select forever location accession."
Issues:
"To continuing giving" → should be "To continue providing" or "To continuously provide"
"the access of location forever" → should be "permanent location access" or "always-on location access"
"forever location accession" → should be "Always Allow" (matching iOS/Android UI terminology)
Suggested translation:
"To continue providing real-time disaster prevention information in the background, DPIP needs 'Always Allow' location permission.\n\nThe system will guide you to the settings page. Please select the 'Always Allow' option."
msgstr "Press the correct button on the top of the list to finish adding the location"
Issue: "Press the correct button" is vague. Consider: "Select a location from the list above to complete setup" or "Tap a location in the list above to set it as your current location"
4. Minor Phrasing (assets/translations/en.po:702)
msgstr "Weather forecast (24 h)"
Suggestion: Consider "Weather Forecast (24h)" or "24-Hour Weather Forecast" for consistency with typical weather app naming
📋 No Code Quality Issues
Since this is a translation file (.po):
✅ No security concerns
✅ No performance issues
✅ No bugs introduced
✅ Proper file encoding (UTF-8)
✅ Valid gettext format
Recommendation
Status:⚠️Approve with Suggestions
The translation updates improve localization coverage, but some translations have grammatical errors or unclear phrasing that could confuse English-speaking users. I recommend:
Option A (Preferred): Update the translations in Crowdin to fix the identified issues, then sync again
Option B: Merge as-is if you want to get these translations out quickly, then create follow-up Crowdin corrections
The most critical issue is the background location permission message (line 924) since it's user-facing during a sensitive permission request flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.