Conversation
package.json
Outdated
| "lint": "eslint .", | ||
| "typedoc": "typedoc", | ||
| "typedoc:watch": "nodemon --watch src --watch theme --ext ts,js,css --exec 'npm run typedoc'", | ||
| "typedoc:serve": "npm run typedoc && npx --yes live-server doc --port=8080 --no-browser", |
There was a problem hiding this comment.
this pulls live-server directly from npm without a lockfile or confirmation. that is unsafe
it should be placed in deps instead
or, better, any package.json changes should be filed as a separate PR from the theme
There was a problem hiding this comment.
Got it
Still working on it actively, it is not yet ready.
But you should be able to already run it locally to see the style changes.
sripwoud
force-pushed
the
sripwoud/theme
branch
from
5c6d0a8 to
9386bae
Compare
sripwoud
force-pushed
the
sripwoud/theme
branch
from
eeded7d to
4f9dd28
Compare
There was a problem hiding this comment.
i removed the change in the deps that included stuff to watch changes during local dev.
However we must update this script to copy files. Otherwise they wont be applied.
Or do you really want this change in package.json to be separate: meaning merging this first style PR will not applied all styles correctly. It would just look like the default typedoc dark theme.
There was a problem hiding this comment.
copying files is fine, thanks!
2 participants
Define a typedoc custom theme that mirror the official docs.exodus.com styles.
This isn't a pixel perfect 1 to 1 mirroring.
It is bit hacky too (lot of
!importantrules), maybe another frontend dev could find a more elegant implementation but it does the job for now I'd say.If you have more exodusoss libs documentation you want to host/publish, I could work on making these css rules a real
typedoc-exoduspackaged theme.