Merged
Conversation
ChALkeR
force-pushed
the
chalker/percentEncodeAfterEncoding/0
branch
from
6ab73f8 to
9b8fd67
Compare
ChALkeR
force-pushed
the
chalker/percentEncodeAfterEncoding/0
branch
7 times, most recently
from
56052c5 to
eacc182
Compare
Collaborator
Author
|
@domenic I think the spec is wrong |
ChALkeR
force-pushed
the
chalker/percentEncodeAfterEncoding/0
branch
15 times, most recently
from
11c6dfc to
3628d3a
Compare
ChALkeR
force-pushed
the
chalker/percentEncodeAfterEncoding/0
branch
from
3628d3a to
f8e5f94
Compare
ChALkeR
force-pushed
the
chalker/percentEncodeAfterEncoding/0
branch
2 times, most recently
from
3a3b77f to
9b7f280
Compare
ChALkeR
force-pushed
the
main
branch
3 times, most recently
from
56ca4f6 to
d30e288
Compare
Collaborator
Author
|
I'm planning to add more cross-tests with browsers and merge this soon. |
ChALkeR
force-pushed
the
chalker/percentEncodeAfterEncoding/0
branch
from
9b7f280 to
931a8b1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChALkeR
force-pushed
the
chalker/percentEncodeAfterEncoding/0
branch
5 times, most recently
from
c5ce31c to
462c3da
Compare
ChALkeR
force-pushed
the
chalker/percentEncodeAfterEncoding/0
branch
from
462c3da to
439fee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @domenic
Ref: https://url.spec.whatwg.org/#string-percent-encode-after-encoding
Api
C0 control percent-encode set is always percent-encoded (below U+0020, U+007F, above U+007F).
Other chars to encode are specified as a literal string
percentEncodeSet, containing unique increasing codepoints in range0x20-0x7e. No sets except C0 are hardcoded.I made this non-fatal, unlike
encodeURIComponentit now normalizes the input to a well-formed string. I can revert that and throw on non-scalarvalue strings instead.The only thing that's not acceptable there is trusting the input to be scalarvalue and returning e.g.
�on\d800In the actual usage all input to the spec-defined method is expected to be scalarvalue.