Conversation
1cc7717 to
2e19abb
Compare
2e19abb to
d11aa2f
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements the iso-2022-jp fatal encoder, completing support for all encoding formats in the Web Platform Tests. The encoder uses a state machine to manage transitions between ASCII, Roman, and JIS0208 character sets via escape sequences.
Changes:
- Added iso-2022-jp encoder implementation with state machine logic for character set transitions
- Removed iso-2022-jp exclusions from WPT test loader
- Added preencoder formula for iso-2022-jp pointer-to-bytes conversion
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/wpt/loader.cjs | Removed iso-2022-jp special case exclusions from encoder tests, enabling validation of the new encoder implementation |
| fallback/multi-byte.js | Added complete iso-2022-jp encoder with state machine (ASCII/Roman/jis0208 states), escape sequence management, halfwidth katakana mapping, and special character handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0a6149e to
cde11eb
Compare
52571f9 to
c3e38cb
Compare
c3e38cb to
5d085d7
Compare
|
This passes basic tests, landing |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Passes on all test data in WPT
But that tests only single-codepoint encode, we need to test more, as iso-2022-jp maintains state
Also need to test failures