feat: add TypeScript type definitions for base58.js#32
Merged
Conversation
Copilot
AI
changed the title
[WIP] Update base58.js to address types issue
Add TypeScript type definitions for base58.js
Jan 22, 2026
ChALkeR
reviewed
Jan 22, 2026
.gitignore
Outdated
Contributor
Author
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
…e safety Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
9a1a983 to
5e925e7
Compare
ChALkeR
reviewed
Jan 22, 2026
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
ChALkeR
approved these changes
Jan 22, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds TypeScript type definitions for the base58.js module, improving type safety and developer experience when using this library in TypeScript projects.
Changes:
- Added comprehensive TypeScript type definitions in
base58.d.tswith function overloads for different return types - Updated
package.jsonto include the types file in the distribution and configure proper type exports - Enhanced README.md with detailed documentation for base58 functions and IETF specification link
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| base58.d.ts | New TypeScript type definitions file with proper overloads for fromBase58, toBase58, fromBase58xrp, and toBase58xrp functions, including JSDoc documentation |
| package.json | Added base58.d.ts to files array and configured exports with types field for proper TypeScript resolution |
| README.md | Added comprehensive documentation for base58 functions with descriptions and links to IETF specification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChALkeR
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base58.d.tsTypeScript type definitions filepackage.jsonto includebase58.d.tsin files arraypackage.jsonexports to include types for base58.jsOriginal prompt
base58.js#26✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.