refactor: NodeStateUpdate to include all fields #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangaman
added
p2p
ghost
assigned
sangaman
force-pushed
the
nodestateupdate
branch
from
25307cc
to
7949b97
Compare
This commit refactors the `NodeStateUpdate` type and the logic around it to include all the fields from the `NodeState` type except those which should be fixed, namely `version` and `nodePubKey`. This is a follow-up to the fix in #876.
sangaman
force-pushed
the
nodestateupdate
branch
from
7949b97
to
7112be0
Compare
ghost
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
NodeStateUpdatetype and the logic around it to include all the fields from theNodeStatetype except those which should not change, namelyversionandnodePubKey. This is a follow-up to the fix in #876.