feat(client): add maximum capacity checks to client #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
sangaman
requested changes
Mar 23, 2019
ghost
force-pushed
the
feat/maximum-capacity-checks-client
branch
2 times, most recently
from
4de636b
to
db0d6cd
Compare
|
Rebased, squashed the commits and applied the feedback. |
sangaman
approved these changes
Mar 26, 2019
ghost
force-pushed
the
feat/maximum-capacity-checks-client
branch
from
db0d6cd
to
0c698a1
Compare
|
Rebased again - @sangaman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #844.
In this PR we're adding a
maximumOutboundCapacityproperty to every client and update it every 60 seconds by querying thechannelBalance. This is required to ultimately add sanity checks beforeOrderbook.placeOrder.