fix(rpc): close streaming calls on shutdown #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Please also handle the case of a node having incoming connection. This will block shutdown too. |
offerm
reviewed
Dec 1, 2018
This tracks all active streaming gRPC calls and closes them when the gRPC server is shut down. Previously, active streaming calls would prevent `xud` from shutting down gracefully. Fixes #699.
sangaman
force-pushed
the
shutdown-streaming
branch
from
39aed70
to
84cfe8a
Compare
|
@offerm I added a line to clear the streams after they've ended. And I think I see what you mean about incoming peers, I'll handle that in a separate PR though. |
offerm
approved these changes
Dec 2, 2018
|
I'll open a separate issue for incoming peers interfering with the shutdown process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #699.
This tracks all active streaming gRPC calls and closes them when the gRPC server is shut down. Previously, active streaming calls would prevent
xudfrom shutting down gracefully.I've tested this and it works well for me. I also confirmed that the
cancelledevent is fired when any streaming call is ended by the client.