fix(lnd): don't default lnd clients as disabled #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
This fixes a bug introduced in #672 whereby the lnd clients are not properly initializing. That PR removed synchronous calls to methods that had asynchronous alternatives, which necessitated moving code from the synchronous `LndClient` constructor to an asynchronous init method. Included in the code that was moved was logic to determine whether to change the client's status from the default value of `Disabled`. This impacted the xud initialization procedure which would only attempt to initialize (or previously verify a connection for) an lnd client that was not disabled. This PR creates a new `NotInitialized` status as the default to reflect the status of a newly created client. It gets changed when the `init` method is called.
sangaman
force-pushed
the
fix/lnd-client-init
branch
from
dedfbfa
to
3030b9c
Compare
sangaman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #672 whereby the lnd clients are not properly initializing. That PR removed synchronous calls to methods that had asynchronous alternatives, which necessitated moving code from the synchronous
LndClientconstructor to an asynchronous init method.Included in the code that was moved was logic to determine whether to change the client's status from the default value of
Disabled. This impacted the xud initialization procedure which would only attemptto initialize (or previously verify a connection for) an lnd client that was not disabled.
This PR creates a new
NotInitializedstatus as the default to reflect the status of a newly created client. It gets changed when theinitmethod is called.