-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swaps): recalculate partial swap amounts #633
Conversation
@ImmanuelSegol Would you mind resolving the conflicts before I review? I know a decent amount was changed so it would be helpful to see what the changes are actually going to look like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing changes to OrderBook.handleSwapRequest
to accept a swap request for a reduced amount if the full amount is not available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs the logic to accept the reduced quantity in the first place, but I'm thinking I can just add that in with a separate PR as it wouldn't hurt to merge this part on its own.
@ImmanuelSegol Needs a rebase too, but I think let's just make these minor changes and then merge before the next release tomorrow. |
I'm thinking that we'll also need changes to the matching logic to try to rematch any part of a swap request that wasn't accepted, I'll try to handle that as well in the next PR. |
closes #550