test: use dynamic port for web proxy tests #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
moshababo
approved these changes
Sep 25, 2018
test/integration/WebProxy.spec.ts
Outdated
| @@ -11,7 +12,7 @@ describe('WebProxy', () => { | |||
| config = { | |||
| webproxy: { | |||
| disable: false, | |||
| port: 8080, | |||
| port: await getUnusedPort(), | |||
There was a problem hiding this comment.
I'd rather have this value be assigned to a var in the beginning of the file/test, in case more usages will pop out.
sangaman
force-pushed
the
proxy-test-port
branch
2 times, most recently
from
501442c
to
3f98141
Compare
This changes the web proxy tests to use a dynamic, unused port instead of the default 8080 port, which could cause the tests to fail if 8080 is being used.
sangaman
force-pushed
the
proxy-test-port
branch
from
3f98141
to
2c2b861
Compare
sangaman
added a commit
that referenced
this pull request
Sep 27, 2018
test: use dynamic port for web proxy tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the web proxy tests to use a dynamic, unused port instead of the default 8080 port, which could cause the tests to fail if 8080 is being used.