feat: peer order match events & alias #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangaman
added
grpc
|
Thanks for checking, I'll get some tests in today and let you know when to try again. |
I guess that's needed to get travis passing? Or do we have travis troubles? |
This enhances the details returned by the `PlaceOrder` call and output by the `placeorder` command to include events for when a peer order is matched and swapping routine begins as well as the alias of the peer whose order we matched with. Closes #1514.
sangaman
force-pushed
the
stream-peer-matches
branch
from
9835a7c
to
fb6ecfd
Compare
|
@raladev I just updated this branch, should be good for another shot now: $ xucli buy 0.001 LTC/BTC mkt
matched 0.001 LTC @ 0.01 with peer OnionToilet order b38d9b80-98eb-11ea-9c49-ffe3e2eb3105, attempting swap...
successfully swapped 0.001 LTC with peer order b38d9b80-98eb-11ea-9c49-ffe3e2eb3105
I just needed to update one of the import references in one of the tests, it should be good now. |
raladev
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances the details returned by the
PlaceOrdercall and output by theplaceordercommand to include events for when a peer order is matched and swapping routine begins as well as the alias of the peer whose order we matched with.Closes #1514.
I still need to test this with some live swaps but was running into issues with Docker, so this could still use some more trial runs.