feat(rpc): CloseChannel call #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael1011
requested changes
Apr 14, 2020
lib/cli/commands/closechannel.ts
Outdated
| import { CloseChannelRequest } from '../../proto/xudrpc_pb'; | ||
| import { callback, loadXudClient } from '../command'; | ||
|
|
||
| export const command = 'closechannel <node_identifier> <currency>'; |
There was a problem hiding this comment.
The [force] parameter is missing here
There was a problem hiding this comment.
This was actually intentional since it's a flag, I'm envisioning it's usage as just adding --force to the command.
It looks like I can put closechannel <node_identifier> <currency> [--force] here and then it'll work either by putting true at the end of the command or --force anywhere in the command, so that's what I'll go with.
sangaman
force-pushed
the
rpc/close-channel
branch
from
49fc80e
to
fe6bba8
Compare
sangaman
force-pushed
the
rpc/close-channel
branch
from
fe6bba8
to
380cb26
Compare
|
Would yo ustill want this for the bot for |
It would be nice to have. I will give this PR another review |
michael1011
approved these changes
Apr 24, 2020
sangaman
force-pushed
the
rpc/close-channel
branch
from
380cb26
to
f69fa7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the ability to close channels through xud. Currently this is only implemented for lnd, and is implemented in a naive way that relies on the peer we are trying to close channels with being online and cooperative.
Closes #1471. Follow-ups are #1472 and #1476.
I've tested this fairly extensively to ensure we are handling the responses from lnd correctly and it's working well.