fix(lnd): relax unhandled openchannel timeout #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangaman
added
bug
michael1011
approved these changes
Apr 9, 2020
ghost
approved these changes
Apr 9, 2020
kilrau
suggested changes
Apr 9, 2020
|
Fixing the test case now. @kilrau I'll open a separate issue for |
This removes the hard timeout placed on each attempt to connect to a peer's lnd node when attempting to open a channel with that peer. This timeout was causing xud to crash because it threw an error that was not being handled in the encapsulating catch block, which did not catch the error because it was thrown from a callback. Rather than attempt to correct the asynchronous exception handling, this lifts the timeout limit set within xud and instead will wait on each connect attempt until it succeeds, times out, or fails according to the logic within lnd. Fixes #1405.
sangaman
force-pushed
the
fix/open-channel
branch
from
f497415
to
b072391
Compare
It makes sense to do in a separate PR since it's not related to fixing the issue described in OP. |
sangaman
requested review from
a user,
michael1011 and
kilrau
and removed request for
michael1011
Yep, sounds good! |
kilrau
approved these changes
Apr 9, 2020
ghost
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the hard timeout placed on each attempt to connect to a peer's lnd node when attempting to open a channel with that peer. This timeout was causing xud to crash because it threw an error that was not being handled in the encapsulating catch block, which did not catch the error because it was thrown from a callback.
Rather than attempt to correct the asynchronous exception handling, this lifts the timeout limit set within xud and instead will wait on each connect attempt until it succeeds, times out, or fails according to the logic within lnd.
Fixes #1405.