feat(logger): optional subcontext #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael1011
approved these changes
Jun 20, 2019
ghost
approved these changes
Jun 24, 2019
| @@ -41,21 +41,6 @@ class SwapClientManager extends EventEmitter { | |||
| this.raidenClient = new RaidenClient(config.raiden, loggers.raiden); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Beautiful! Loving that we get to delete this code.
This adds an optional subcontext for loggers to print on every log statement. This is used in place of wrapping the log methods for the lnd loggers to display currency, but can also be reused in a generic fashion going forward. Before: ``` 19/06/2019 15:44:43.634 [LND] info: BTC: trying to verify connection... ``` After: ``` 19/06/2019 15:44:43.634 [LND-BTC] info: trying to verify connection... ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional subcontext for loggers to print on every log statement. This is used in place of wrapping the log methods for the lnd loggers to display currency, but can also be reused in a generic fashion going forward.
Before:
After:
This is an offshoot of #1039.