Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamOrders - wait for XUD #687

Closed
offerm opened this issue Nov 18, 2018 · 0 comments · Fixed by #780
Closed

streamOrders - wait for XUD #687

offerm opened this issue Nov 18, 2018 · 0 comments · Fixed by #780
Assignees
@rsercano
Labels
command line (CLI) Relating to the command line interface tools enhancement New feature or request has PR issues with an open PR
Milestone
1.0.0-alpha.7

Comments

@offerm
Copy link
Contributor

offerm commented Nov 18, 2018

Enhance streamorders CLI in the following ways:

a. allow it to start before xud. streamorders should wait for xud to start and not issue an error. It is OK to issue a warn/info for waiting for XUD.

b. print a line upon connection

c. upon termination of xud or any other RPC error - reconnect to xud (wait if xud is not available.

d. upon connection to xud - print existing orders.

With these changes it will be easier to track xud internals.
@offerm offerm added this to the 1.0.0-alpha.5 milestone Nov 18, 2018
@sangaman sangaman added the command line (CLI) Relating to the command line interface tools label Nov 18, 2018
@kilrau kilrau modified the milestones: 1.0.0-alpha.5, 1.0.0-alpha.6 Nov 20, 2018
@kilrau kilrau assigned ghost and unassigned sangaman Dec 6, 2018
@kilrau kilrau added the enhancement New feature or request label Dec 6, 2018
@kilrau kilrau modified the milestones: 1.0.0-alpha.6, 1.0.0-alpha.8 Jan 2, 2019
@kilrau kilrau assigned rsercano and unassigned ghost Jan 2, 2019
rsercano pushed a commit to rsercano/xud that referenced this issue Jan 7, 2019
improved subscribeorders ExchangeUnion#687
69ee090
@rsercano rsercano mentioned this issue Jan 7, 2019
Merged
4 tasks
@moshababo moshababo added the has PR issues with an open PR label Jan 7, 2019
rsercano pushed a commit to rsercano/xud that referenced this issue Jan 7, 2019
requested changes ExchangeUnion#687
80f1c22
rsercano pushed a commit to rsercano/xud that referenced this issue Jan 7, 2019
requested changes ExchangeUnion#687
94bbb4a
rsercano pushed a commit to rsercano/xud that referenced this issue Jan 8, 2019
requested changes ExchangeUnion#687
44880d9
rsercano pushed a commit to rsercano/xud that referenced this issue Jan 15, 2019
changed variable type ExchangeUnion#687
54266ef
sangaman pushed a commit that referenced this issue Jan 15, 2019
@rsercano @sangaman
feat(cli): improved streamorders (#780)
6084043 
This commit changes the behavior of the `streamorders` cli call:

1. Allow it to start before xud. `streamorders` will wait for xud to
start and not issue an error.
2. Print a line upon connection.
3. Upon termination of xud or any other RPC error - reconnect to xud
and wait if xud is not available.
4. Upon connection to xud - print existing orders.

Closes #687.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsercano rsercano

Labels
command line (CLI) Relating to the command line interface tools enhancement New feature or request has PR issues with an open PR
Projects
None yet
Milestone
1.0.0-alpha.7
Development

Successfully merging a pull request may close this issue.

improved streamOrders #687 rsercano/xud
5 participants
@sangaman @rsercano @offerm @moshababo @kilrau