Prepare database for #608 and #562 #621
Comments
sangaman
added a commit
that referenced
this issue
Oct 31, 2018
This commit creates new database models for orders and trades. The `Order` model is used to persist all data related to a specific order, whereas the `Trade` model will be used for persisting data about completed trades. Some order-specific properties from `SwapDeal` have moved to the `Order` model. Rather than repeat that data for each `SwapDeal` instance that swaps the same order, which results in data duplication and creates the possibility for inconsistencies, swaps for the same order now point to the same `Order` instance. This also attempts to add all known associations between models for easy join queries via the Sequelize API going forward. Closes #621.
ghost
added
the
sangaman
added a commit
that referenced
this issue
Oct 31, 2018
This commit creates new database models for orders and trades. The `Order` model is used to persist all data related to a specific order, whereas the `Trade` model will be used for persisting data about completed trades. Some order-specific properties from `SwapDeal` have moved to the `Order` model. Rather than repeat that data for each `SwapDeal` instance that swaps the same order, which results in data duplication and creates the possibility for inconsistencies, swaps for the same order now point to the same `Order` instance. This also attempts to add all known associations between models for easy join queries via the Sequelize API going forward. Closes #621.
sangaman
added a commit
that referenced
this issue
Oct 31, 2018
This commit creates new database models for orders and trades. The `Order` model is used to persist all data related to a specific order, whereas the `Trade` model will be used for persisting data about completed trades. Some order-specific properties from `SwapDeal` have moved to the `Order` model. Rather than repeat that data for each `SwapDeal` instance that swaps the same order, which results in data duplication and creates the possibility for inconsistencies, swaps for the same order now point to the same `Order` instance. This also attempts to add all known associations between models for easy join queries via the Sequelize API going forward. Closes #621.
sangaman
added a commit
that referenced
this issue
Oct 31, 2018
This commit creates new database models for orders and trades. The `Order` model is used to persist all data related to a specific order, whereas the `Trade` model will be used for persisting data about completed trades. Some order-specific properties from `SwapDeal` have moved to the `Order` model. Rather than repeat that data for each `SwapDeal` instance that swaps the same order, which results in data duplication and creates the possibility for inconsistencies, swaps for the same order now point to the same `Order` instance. This also attempts to add all known associations between models for easy join queries via the Sequelize API going forward. Closes #621.
sangaman
added a commit
that referenced
this issue
Nov 9, 2018
This commit creates new database models for orders and trades. The `Order` model is used to persist all data related to a specific order, whereas the `Trade` model will be used for persisting data about completed trades. Some order-specific properties from `SwapDeal` have moved to the `Order` model. Rather than repeat that data for each `SwapDeal` instance that swaps the same order, which results in data duplication and creates the possibility for inconsistencies, swaps for the same order now point to the same `Order` instance. This also attempts to add all known associations between models for easy join queries via the Sequelize API going forward. Closes #621.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This prepares the database to support #562 & #608 so we don't have breaking changes later
The text was updated successfully, but these errors were encountered: