-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failed swaps to placeOrder (buy/sell) response #609
Comments
So instead of only persisting it in the db as per #562 you suggest also to return failed swap info in Important imo: |
It would be for both the sync and streaming place order calls, but yeah otherwise that's right. Altho even if a swap never succeeds, we'd still want to return any swaps that failed. |
Solves parts of #620 |
Output today:
How it should be:
|
This adds a `FailedSwap` message type to the asynchronous `PlaceOrder` rpc call. It is used to notify the caller in real time when a swap fails for a given order. Closes #609.
This adds a `SwapFailure` message type to the asynchronous `PlaceOrder` rpc call. It is used to notify the caller in real time when a swap fails for a given order. This also renames `SwapResult` to `SwapSuccess` to clearly distinguish it from the unsuccessful `SwapFailure`. Closes #609. Closes #734.
This adds a `SwapFailure` message type to the asynchronous `PlaceOrder` rpc call. It is used to notify the caller in real time when a swap fails for a given order. This also renames `SwapResult` to `SwapSuccess` to clearly distinguish it from the unsuccessful `SwapFailure`. Closes #609. Closes #734.
It might be useful to know whether a placed order attempted to swap with any peer orders but failed. Currently
placeOrder
only returns information about successful swaps and internal matches. We could make it also return failed swaps. I figure for each failed swap we'd want to know theorderId
and maybequantity
andpeerPubKey
, maybe the error message for why the swap failed`? Comment if you can think of anything else that might be worth returning.The text was updated successfully, but these errors were encountered: