Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove peer orders for dropped trading pairs #599

Closed
sangaman opened this issue Oct 23, 2018 · 0 comments
Closed

Remove peer orders for dropped trading pairs #599

sangaman opened this issue Oct 23, 2018 · 0 comments
Assignees
@sangaman
Labels
has PR issues with an open PR order book P2 mid priority
Milestone
1.0.0-alpha.6

Comments

@sangaman
Copy link
Collaborator

As discussed in #585, when a peer drops support for a trading pair in a handshake update, we should drop all orders for that peer and trading pair locally.
@sangaman sangaman self-assigned this Oct 23, 2018
@kilrau kilrau added the P2 mid priority label Oct 26, 2018
@kilrau kilrau added this to the 1.0.0-alpha.4 milestone Oct 26, 2018
sangaman added a commit that referenced this issue Nov 30, 2018
@sangaman
feat(p2p/orderbook): drop orders for dropped pairs
0d6f8d5 
This adds logic to drop a peer's orders for a given trading pair when
we receive an updated handshake state that does not include a trading
pair that was supported according to the previous handshake. Without
this, we may keep orders in our order book for a peer that no longer
supports (and can swap) those orders.

Closes #599.
@sangaman sangaman mentioned this issue Nov 30, 2018
Merged
@ghost ghost added the in progress label Nov 30, 2018
@kilrau kilrau modified the milestones: 1.0.0-alpha.5, 1.0.0-alpha.6 Dec 5, 2018
@kilrau kilrau added the has PR issues with an open PR label Dec 6, 2018
sangaman added a commit that referenced this issue Dec 17, 2018
@sangaman
feat(p2p/orderbook): drop orders for dropped pairs
53a1c35 
This adds logic to drop a peer's orders for a given trading pair when
we receive an updated handshake state that does not include a trading
pair that was supported according to the previous handshake. Without
this, we may keep orders in our order book for a peer that no longer
supports (and can swap) those orders.

Closes #599.
sangaman added a commit that referenced this issue Dec 24, 2018
@sangaman
feat(p2p/orderbook): drop orders for dropped pairs
f9a40c2 
This adds logic to drop a peer's orders for a given trading pair when
we receive an updated handshake state that does not include a trading
pair that was supported according to the previous handshake. Without
this, we may keep orders in our order book for a peer that no longer
supports (and can swap) those orders.

Closes #599.
@ghost ghost removed the in progress label Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

Labels
has PR issues with an open PR order book P2 mid priority
Projects
None yet
Milestone
1.0.0-alpha.6
Development

No branches or pull requests
2 participants
@sangaman @kilrau