Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show txid instead of success #1860

Closed
kilrau opened this issue Sep 1, 2020 · 1 comment · Fixed by #1867
Closed

Show txid instead of success #1860

kilrau opened this issue Sep 1, 2020 · 1 comment · Fixed by #1867
Assignees
@rsercano
Labels
connext P2 mid priority

Comments

@kilrau
Copy link
Contributor

kilrau commented Sep 1, 2020

How it is

Typical flow of a connext channel deposit:

mainnet > openchannel usdt 100
success

Connext client submits the txid in the response, let's display it just like we already do for other on-chain operations:

{
tx id: "123"
}
@kilrau kilrau added P2 mid priority connext labels Sep 1, 2020
@kilrau
Copy link
Contributor Author

kilrau commented Sep 4, 2020

openchannel + closechannel both should show the txid

@rsercano rsercano mentioned this issue Sep 4, 2020
Merged
sangaman pushed a commit that referenced this issue Sep 11, 2020
@rsercano @sangaman
feat(rpc): add txid to open/close channel response
0669a3f 
Closes #1860.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsercano rsercano

Labels
connext P2 mid priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Open/close channel txid show instead of success ExchangeUnion/xud
2 participants
@rsercano @kilrau