Xud crash for taker after some sucessful/unsuccessful swaps #1851
Comments
|
Maker logs: https://paste.ubuntu.com/p/t2cpndGT6Q/ |
|
Maker: |
|
As just discussed with @sangaman , we would want to catch this error and make xud not crash for this error, just print an error message and keep going. As of now, we can't come up with a path that could be "dangerous" for continuing after a deal successfully completed. It's too late anyways 🤷♂️ |
sangaman
added a commit
that referenced
this issue
Aug 31, 2020
This prevents trying to settle an invoice more than once in case Connext sends us duplicate transfer received events. Previously, ConnextClient would emit the `htlcAccepted` event multiple times, resulting in one successful settleInvoice call and at least one failed call, which would then attempt to fail a completed deal and crash xud. Closes #1851.
sangaman
added a commit
that referenced
this issue
Aug 31, 2020
This prevents trying to settle an invoice more than once in case Connext sends us duplicate transfer received events. Previously, ConnextClient could emit the `htlcAccepted` event multiple times, resulting in one successful settleInvoice call and at least one failed call, which would then attempt to fail a completed deal and crash xud. Closes #1851.
raladev
pushed a commit
that referenced
this issue
Sep 1, 2020
* fix(connext): prevent duplicate htlcAccepted evts This prevents trying to settle an invoice more than once in case Connext sends us duplicate transfer received events. Previously, ConnextClient could emit the `htlcAccepted` event multiple times, resulting in one successful settleInvoice call and at least one failed call, which would then attempt to fail a completed deal and crash xud. Closes #1851. * refactor(swaps): relax faildeal complete check This relaxes the assertion in `failDeal` to ensure we don't "fail" a deal that has already been completed. Previously such a case would crash xud, now it only prints an error message and does nothing. Although this shouldn't happen and indicates a flaw with xud code should it arise, it is not a critical error and does not risk funds or indicate that xud is inoperable.
rsercano
pushed a commit
that referenced
this issue
Sep 11, 2020
* fix(connext): prevent duplicate htlcAccepted evts This prevents trying to settle an invoice more than once in case Connext sends us duplicate transfer received events. Previously, ConnextClient could emit the `htlcAccepted` event multiple times, resulting in one successful settleInvoice call and at least one failed call, which would then attempt to fail a completed deal and crash xud. Closes #1851. * refactor(swaps): relax faildeal complete check This relaxes the assertion in `failDeal` to ensure we don't "fail" a deal that has already been completed. Previously such a case would crash xud, now it only prints an error message and does nothing. Although this shouldn't happen and indicates a flaw with xud code should it arise, it is not a critical error and does not risk funds or indicate that xud is inoperable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Taker logs:
testnet_connext_taker.log
testnet_utils_taker.log
testnet_xud_crash_taker.log
!
The text was updated successfully, but these errors were encountered: