Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connext is blocking tradinglimits request if connext node is unavailable #1766

Closed
raladev opened this issue Jul 29, 2020 · 0 comments · Fixed by #1784
Closed

connext is blocking tradinglimits request if connext node is unavailable #1766

raladev opened this issue Jul 29, 2020 · 0 comments · Fixed by #1784
Assignees
@sangaman @kilrau
Labels
bug Something isn't working P2 mid priority

Comments

@raladev
Copy link
Contributor

raladev commented Jul 29, 2020

It looks like this one - #1572

Screenshot from 2020-07-29 16-47-45

Steps to reproduce:

  1. Turn off Ethernet
  2. tradinglimits

Actual result:
Connext error
@raladev raladev added bug Something isn't working P2 mid priority labels Jul 29, 2020
@raladev raladev changed the title connext blocks tradinglimits request if connext node is unavailable connext is blocking tradinglimits request if connext node is unavailable Jul 29, 2020
sangaman added a commit that referenced this issue Aug 5, 2020
@sangaman
fix(rpc): don't block TradingLimits on failure
50a12a1 
This doesn't fail the entire `TradingLimits` call when a subset of the
swap clients hit an error when checking their inbound/outbound capacity.
If we get an error for one client, we will log it but still return
limits from other clients.

Fixes #1766.
@sangaman sangaman mentioned this issue Aug 5, 2020
Merged
raladev pushed a commit that referenced this issue Aug 5, 2020
@sangaman
fix(rpc): don't block TradingLimits on failure (#1784)
43ae535 
This doesn't fail the entire `TradingLimits` call when a subset of the
swap clients hit an error when checking their inbound/outbound capacity.
If we get an error for one client, we will log it but still return
limits from other clients.

Fixes #1766.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

@kilrau kilrau

Labels
bug Something isn't working P2 mid priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rpc): don't block TradingLimits on failure ExchangeUnion/xud
3 participants
@sangaman @kilrau @raladev