Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [SWAPS] Successfully executed swap log entry #1649

Closed
kilrau opened this issue Jun 12, 2020 · 0 comments · Fixed by #1943
Closed

Add [SWAPS] Successfully executed swap log entry #1649

kilrau opened this issue Jun 12, 2020 · 0 comments · Fixed by #1943
Assignees
@rsercano
Labels
enhancement New feature or request logging Log messages and output P3 low priority swaps

Comments

@kilrau
Copy link
Contributor

kilrau commented Jun 12, 2020 •
edited
Loading

From the logs it's clear where a swap procedure begins, but not where it ends. We would want to add an entry along the lines

12/06/2020 14:41:23.855 [SWAPS] Successfully executed swap 6e94f2d976bbb2e9fbf380c8644199f7cab513e13c4ace2c9e85c70dabc6100c with peer 02d7348d32c1e97f38c582946e4430a924c7a274d03051865a7e6a7d542cce642b (CheeseMonkey)

in the default log level (currently debug I believe).
@kilrau kilrau added enhancement New feature or request P2 mid priority swaps logging Log messages and output labels Jun 12, 2020
@kilrau kilrau added P3 low priority and removed P2 mid priority labels Jun 12, 2020
@kilrau kilrau assigned rsercano and unassigned sangaman Oct 19, 2020
rsercano added a commit that referenced this issue Oct 20, 2020
@rsercano
fix: added swap success log entry (#1649)
3b74ca7
@rsercano rsercano mentioned this issue Oct 20, 2020
Merged
rsercano added a commit that referenced this issue Oct 20, 2020
@rsercano
fix: added swap success log entry (#1649)
75bf98d
rsercano added a commit that referenced this issue Oct 20, 2020
@rsercano
fix: added swap success log entry (#1649)
0b8c284
rsercano added a commit that referenced this issue Oct 20, 2020
@rsercano
fix: added swap success log entry (#1649)
b227447
rsercano added a commit that referenced this issue Oct 21, 2020
@rsercano
fix: added swap success log entry (#1649)
3b1e6d1
rsercano added a commit that referenced this issue Oct 21, 2020
@rsercano
fix: added swap success log entry (#1649)
e914ec0
sangaman added a commit that referenced this issue Oct 27, 2020
@sangaman
Merge pull request #1943 from ExchangeUnion/fix/added-swap-success-lo…
69980e7 
…g-entry

fix: added swap success log entry (#1649)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsercano rsercano

Labels
enhancement New feature or request logging Log messages and output P3 low priority swaps
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added swap success log entry (#1649) ExchangeUnion/xud
3 participants
@sangaman @rsercano @kilrau