Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwapRecovery v2 #1606

Closed
kilrau opened this issue Jun 8, 2020 · 0 comments · Fixed by #1617
Closed

SwapRecovery v2 #1606

kilrau opened this issue Jun 8, 2020 · 0 comments · Fixed by #1617
Assignees
@sangaman @kilrau
Labels
bug Something isn't working P1 top priority

Comments

@kilrau
Copy link
Contributor

kilrau commented Jun 8, 2020

https://github.com/ExchangeUnion/xud/tree/fix/swap-recovery still has an issue where an unclaimed payment (taker) is not entering the swap recovery path.
@kilrau kilrau added bug Something isn't working P1 top priority labels Jun 8, 2020
sangaman added a commit that referenced this issue Jun 9, 2020
@sangaman
fix(swaps): go to recovery for all failures
ed2d64f 
This fixes a bug where failed swaps in the `SendingPayment` phase as
maker would only be tracked by the `SwapRecovery` module if they failed
due to a timeout error.

Closes #1606.
@sangaman sangaman mentioned this issue Jun 9, 2020
Merged
sangaman added a commit that referenced this issue Jun 9, 2020
@sangaman
fix(swaps): go to recovery for all failures
43f38d2 
This fixes a bug where failed swaps in the `SendingPayment` phase as
maker would only be tracked by the `SwapRecovery` module if they failed
due to a timeout error.

Closes #1606.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

@kilrau kilrau

Labels
bug Something isn't working P1 top priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(swaps): go to recovery for all failures ExchangeUnion/xud
2 participants
@sangaman @kilrau