Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let xucli automatically determine gRPC port #1451

Closed
kilrau opened this issue Apr 1, 2020 · 0 comments · Fixed by #1462
Closed

Let xucli automatically determine gRPC port #1451

kilrau opened this issue Apr 1, 2020 · 0 comments · Fixed by #1462
Assignees
Labels
P2 mid priority

Comments

@kilrau
Copy link
Contributor

kilrau commented Apr 1, 2020

Now that we have

mainnet: 8886
testnet: 18886
simnet: 28886

one has to specify -p for xucli when running a non-mainnet network. Let's check how we can have xucli read from the xud config file (or another way) to determine what port it's running on?

@kilrau kilrau added the P2 mid priority label Apr 1, 2020
sangaman added a commit that referenced this issue Apr 8, 2020
This enhances the cli to automatically attempt to find and read from
the xud configuration file to determine the port and host for the xud
gRPC service based on the configured network - which determines default
port numbers - or configured port if specified. This prevents the user
from having to specify the rpc port on `xucli` commands when using a
non-mainnet xud instance or a non-default gRPC port via the config file.

Closes #1451.
sangaman added a commit that referenced this issue Apr 8, 2020
This enhances the cli to automatically attempt to find and read from
the xud configuration file to determine the port and host for the xud
gRPC service based on the configured network - which determines default
port numbers - or configured port if specified. This prevents the user
from having to specify the rpc port on `xucli` commands when using a
non-mainnet xud instance or a non-default gRPC port via the config file.

Closes #1451.
sangaman added a commit that referenced this issue Apr 13, 2020
This enhances the cli to automatically attempt to find and read from
the xud configuration file to determine the port and host for the xud
gRPC service based on the configured network - which determines default
port numbers - or configured port if specified. This prevents the user
from having to specify the rpc port on `xucli` commands when using a
non-mainnet xud instance or a non-default gRPC port via the config file.

Closes #1451.
sangaman added a commit that referenced this issue Apr 15, 2020
This enhances the cli to automatically attempt to find and read from
the xud configuration file to determine the port and host for the xud
gRPC service based on the configured network - which determines default
port numbers - or configured port if specified. This prevents the user
from having to specify the rpc port on `xucli` commands when using a
non-mainnet xud instance or a non-default gRPC port via the config file.

Closes #1451.
sangaman added a commit that referenced this issue Apr 15, 2020
This enhances the cli to automatically attempt to find and read from
the xud configuration file to determine the port and host for the xud
gRPC service based on the configured network - which determines default
port numbers - or configured port if specified. This prevents the user
from having to specify the rpc port on `xucli` commands when using a
non-mainnet xud instance or a non-default gRPC port via the config file.

Closes #1451.
@ghost ghost closed this as completed in #1462 Apr 15, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 mid priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants