Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executeswap is not working #1175

Closed
rsercano opened this issue Aug 23, 2019 · 0 comments · Fixed by #1178
Closed

executeswap is not working #1175

rsercano opened this issue Aug 23, 2019 · 0 comments · Fixed by #1178
Assignees
@kilrau
Labels
bug Something isn't working command line (CLI) Relating to the command line interface tools grpc gRPC API has PR issues with an open PR

Comments

@rsercano
Copy link
Collaborator

As per our discussion with @kilrau nomatching mode is not being maintained currently but while in that mode, executeswap command fails with the following error;

✘ sercan@aytws08  ~/WebstormProjects/xud-master/bin   list-swaps  ./xucli executeswap 'LTC/BTC' '234a1010-a23a-11e9-ab41-07bcb608d898'

/home/sercan/WebstormProjects/xud-master/node_modules/yargs/yargs.js:1133
      else throw err
           ^
AssertionError: Assertion failed
    at new goog.asserts.AssertionError (/home/sercan/WebstormProjects/xud-master/node_modules/google-protobuf/google-protobuf.js:98:603)
    at Object.goog.asserts.doAssertFailure_ (/home/sercan/WebstormProjects/xud-master/node_modules/google-protobuf/google-protobuf.js:99:126)
    at Object.goog.asserts.assert (/home/sercan/WebstormProjects/xud-master/node_modules/google-protobuf/google-protobuf.js:99:385)
    at jspb.BinaryWriter.writeUint64 (/home/sercan/WebstormProjects/xud-master/node_modules/google-protobuf/google-protobuf.js:278:266)
    at Function.proto.xudrpc.ExecuteSwapRequest.serializeBinaryToWriter (/home/sercan/WebstormProjects/xud-master/dist/proto/xudrpc_pb.js:3032:12)
    at proto.xudrpc.ExecuteSwapRequest.serializeBinary (/home/sercan/WebstormProjects/xud-master/dist/proto/xudrpc_pb.js:2995:35)
    at serialize_xudrpc_ExecuteSwapRequest (/home/sercan/WebstormProjects/xud-master/dist/proto/xudrpc_grpc_pb.js:187:26)
    at Object.final_requester.sendMessage (/home/sercan/WebstormProjects/xud-master/node_modules/grpc/src/client_interceptors.js:806:37)
    at InterceptingCall._callNext (/home/sercan/WebstormProjects/xud-master/node_modules/grpc/src/client_interceptors.js:419:43)
    at InterceptingCall.sendMessage (/home/sercan/WebstormProjects/xud-master/node_modules/grpc/src/client_interceptors.js:464:8)
@rsercano rsercano added bug Something isn't working grpc gRPC API command line (CLI) Relating to the command line interface tools labels Aug 23, 2019
sangaman added a commit that referenced this issue Aug 23, 2019
@sangaman
fix(cli): executeswap don't set undefined quantity
8e61343 
The `coinsToSats` method expects a number, but when a quantity is not
defined as a command argument then it gets passed `undefined` and
returns `NaN`. Instead, we should not call this method when `quantity`
is not defined and leave it as its default value on the gRPC call.

Fixes #1175.
@sangaman sangaman mentioned this issue Aug 23, 2019
Merged
@rsercano rsercano added the has PR issues with an open PR label Aug 26, 2019
sangaman added a commit that referenced this issue Sep 11, 2019
@sangaman
fix(cli): executeswap don't set undefined quantity
a9a6744 
The `coinsToSats` method expects a number, but when a quantity is not
defined as a command argument then it gets passed `undefined` and
returns `NaN`. Instead, we should not call this method when `quantity`
is not defined and leave it as its default value on the gRPC call.

Fixes #1175.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kilrau kilrau

Labels
bug Something isn't working command line (CLI) Relating to the command line interface tools grpc gRPC API has PR issues with an open PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): executeswap don't set undefined quantity ExchangeUnion/xud
2 participants
@rsercano @kilrau