channel balance (raiden)

[offerm]

I have two tokens defined (WETH, DAI) and one channel with another node. The channel balance is 1e18.

When I use xucli channelbalance I see the balance reported for both tokens.

xud@xud-test-1:~/scripts/raiden/exchange$ xucli channelbalance
{
  "balancesMap": [
    [
      "BTC",
      {
        "balance": 3750157448,
        "pendingOpenBalance": 0
      }
    ],
    [
      "DAI",
      {
        "balance": 1000000000000000000,
        "pendingOpenBalance": 0
      }
    ],
    [
      "LTC",
      {
        "balance": 226339963038,
        "pendingOpenBalance": 0
      }
    ],
    [
      "WETH",
      {
        "balance": 1000000000000000000,
        "pendingOpenBalance": 0
      }
    ]
  ]
}

[offerm]

In case both channels have balance, there is a different problem:

xud@xud-test-1:~/raiden$ curl http://localhost:5001/api/v1/channels|jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   734  100   734    0     0  52954      0 --:--:-- --:--:-- --:--:-- 56461
[
  {
    "total_deposit": 1.5e+20,
    "token_address": "0x9F50cEA29307d7D91c5176Af42f3aB74f0190dD3",
    "token_network_identifier": "0x23a7036a025FEF30A38f1f3464FFbe2b02a5a627",
    "reveal_timeout": 50,
    "balance": 1.5e+20,
    "settle_timeout": 500,
    "state": "opened",
    "channel_identifier": 1,
    "partner_address": "0x2B88992DEd5C96aa7Eaa9CFE1AE52350df7dc5DF"
  },
  {
    "total_deposit": 7e+20,
    "token_address": "0x76671A2831Dc0aF53B09537dea57F1E22899655d",
    "token_network_identifier": "0x52878c603046eC04647bEc9729c132FD1b72Ec6B",
    "reveal_timeout": 50,
    "balance": 7e+20,
    "settle_timeout": 500,
    "state": "opened",
    "channel_identifier": 1,
    "partner_address": "0x2B88992DEd5C96aa7Eaa9CFE1AE52350df7dc5DF"
  }
]
xud@xud-test-1:~/raiden$ xucli channelbalance
Error: 13 INTERNAL: Assertion failed

[kilrau]

Summary of bugs to be fixed:

1. if two raiden token network (e.g. weth) have a channel with balance, xucli channelbalance shows both token networks with the sum of both channel balances.
2. if all registered token networks have a channel with balance, xucli channelbalance throws Error: 13 INTERNAL: Assertion failed

[offerm]

I see assertion failed also with a single channel

xud@xud-test-3:~$ curl  http://localhost:5001/api/v1/channels|jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   347  100   347    0     0  25458      0 --:--:-- --:--:-- --:--:-- 26692
[
  {
    "balance": 1.8e+20,
    "token_network_identifier": "0x52878c603046eC04647bEc9729c132FD1b72Ec6B",
    "token_address": "0x76671A2831Dc0aF53B09537dea57F1E22899655d",
    "settle_timeout": 500,
    "state": "opened",
    "reveal_timeout": 50,
    "total_deposit": 0,
    "partner_address": "0x7ed0299Fa1ADA71D10536B866231D447cDFa48b9",
    "channel_identifier": 4
  }
]
xud@xud-test-3:~$ xucli channelbalance
Error: 13 INTERNAL: Assertion failed

[kilrau]

Bump up to 1.0.0-testnet P1 since this makes it very hard to figure out what's going on and prove for bug bounty hunters that money was stolen.

[sangaman]

I believe the Assertion Failed errors are happening because we wind up with numbers greater than the max for uint64. With each whole unit being 10^18 it can add up pretty quickly. In #1066 I'm standardizing the balances returned to satoshi units, in a future PR for the cli I can modify it to print whole units, so the balance prints like 1.5 WETH instead of 15 and a bunch of zeros.

[kilrau]

@sangaman Pls give this a manual test