simtest

test/integration/OrderBook.spec.ts

@@ -252,12 +252,12 @@ describe('nomatching OrderBook', () => {
     orderBook['removeOwnOrder']({
       orderId: remainingOrder!.id,
       pairId: order.pairId,
-      quantityToRemove: remainingOrder!.quantity - 100
+      quantityToRemove: remainingOrder!.quantity - 100,
     });
     orderBook['removeOwnOrder']({
       orderId: remainingOrder!.id,
       pairId: order.pairId,
-      quantityToRemove: 100
+      quantityToRemove: 100,
     });
 
     expect(() => orderBook['removeOwnOrder']({

test/simulation/tests-integration.go

@@ -23,6 +23,10 @@ var integrationTestCases = []*testCase{
 		name: "order matching and swap connext",
 		test: testOrderMatchingAndSwapConnext,
 	},
+	{
+		name: "order replacement",
+		test: testOrderReplacement,
+	},
 	{
 		name: "internal match and invalidation",
 		test: testInternalMatchAndInvalidation,
@@ -252,6 +256,83 @@ func testOrderMatchingAndSwap(net *xudtest.NetworkHarness, ht *harnessTest) {
 	ht.act.disconnect(net.Alice, net.Bob)
 }
 
+func testOrderReplacement(net *xudtest.NetworkHarness, ht *harnessTest) {
+	// Connect Alice to Bob.
+	ht.act.connect(net.Alice, net.Bob)
+	ht.act.verifyConnectivity(net.Alice, net.Bob)
+
+	var originalQuantity uint64 = 1000000
+	originalPrice := 0.02
+	var newQuantity uint64 = 2000000
+	newPrice := 0.03
+
+	// Place an order on Alice.
+	req := &xudrpc.PlaceOrderRequest{
+		OrderId:  "maker_order_id",
+		Price:    originalPrice,
+		Quantity: originalQuantity,
+		PairId:   "LTC/BTC",
+		Side:     xudrpc.OrderSide_BUY,
+	}
+	ht.act.placeOrderAndBroadcast(net.Alice, net.Bob, req)
+
+	// Subscribe to orders on Bob
+	bobOrderChan := subscribeOrders(ht.ctx, net.Bob)
+
+	// Replace the order on Alice
+	req = &xudrpc.PlaceOrderRequest{
+		ReplaceOrderId: "maker_order_id",
+		Price:          newPrice,
+		Quantity:       newQuantity,
+		PairId:         req.PairId,
+		Side:           req.Side,
+	}
+	res, err := net.Bob.Client.PlaceOrderSync(ht.ctx, req)
+	ht.assert.NoError(err)
+	ht.assert.Len(res.InternalMatches, 0)
+	ht.assert.Len(res.SwapSuccesses, 0)
+	ht.assert.Len(res.SwapFailures, 0)
+	ht.assert.NotNil(res.RemainingOrder)
+	ht.assert.True(res.RemainingOrder.IsOwnOrder)
+
+	// Retrieve and verify the removed order event on Bob.
+	e := <-bobOrderChan
+	ht.assert.NoError(e.err)
+	ht.assert.NotNil(e.orderUpdate)
+	orderRemoval := e.orderUpdate.GetOrderRemoval()
+	ht.assert.NotNil(orderRemoval)
+	ht.assert.Equal(orderRemoval.Quantity, originalQuantity)
+	ht.assert.Equal(orderRemoval.LocalId, "maker_order_id")
+	ht.assert.Equal(orderRemoval.PairId, req.PairId)
+	ht.assert.False(orderRemoval.IsOwnOrder)
+
+	// Retrieve and verify the added order event on Bob.
+	e = <-bobOrderChan
+	ht.assert.NoError(e.err)
+	ht.assert.NotNil(e.orderUpdate)
+	peerOrder := e.orderUpdate.GetOrder()
+	ht.assert.NotNil(peerOrder)
+
+	// Verify the peer order.
+	ht.assert.Equal(peerOrder.Price, newPrice)
+	ht.assert.Equal(peerOrder.PairId, req.PairId)
+	ht.assert.Equal(peerOrder.Quantity, newQuantity)
+	ht.assert.Equal(peerOrder.Side, req.Side)
+	ht.assert.False(peerOrder.IsOwnOrder)
+	ht.assert.Equal(peerOrder.NodeIdentifier.NodePubKey, net.Alice.PubKey())
+
+	// Verify that only the replaced order is in the order books
+	srcNodeCount, destNodeCount, err := getOrdersCount(ht.ctx, net.Alice, net.Bob)
+	ht.assert.NoError(err)
+	ht.assert.Equal(srcNodeCount.Own, 1)
+	ht.assert.Equal(srcNodeCount.Peer, 0)
+	ht.assert.Equal(destNodeCount.Own, 0)
+	ht.assert.Equal(destNodeCount.Peer, 1)
+
+	// Cleanup.
+	ht.act.disconnect(net.Alice, net.Bob)
+}
+
 func waitConnextReady(node *xudtest.HarnessNode) error {
 	isReady := func() bool {
 		info, err := node.Client.GetInfo(context.Background(), &xudrpc.GetInfoRequest{})