Alter fillpatch and boundary plane calls for overset simulations #1358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchdf
reviewed
Nov 20, 2024
|
I like where this is going. I just had a minor thought on clarity of naming functions. |
|
The way I set it up should still be correct with multiple iterations in AMR-Wind, too |
mbkuhn
changed the title
mbkuhn
changed the title
This reverts commit ec90bf7.
…& make fillpatch time smart in TiogaInterface
mbkuhn
force-pushed
the
overset_fillpatch_bdyplane
branch
from
be187ce to
c3bda77
Compare
|
it would be good to accompany this with an exawind-driver reg test |
|
Good work! |
marchdf
approved these changes
Nov 27, 2024
jrood-nrel
pushed a commit
to jrood-nrel/amr-wind
that referenced
this pull request
Jun 3, 2025
…wind#1358) * introduce bool to CFDSim to know which part of overset step we're in & make fillpatch time smart in TiogaInterface * change when pre_advance_work happens for boundary planes with overset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because exawind-driver calls exchange_solution (and thereby, fillpatch) more than the plain AMR-Wind algorithm, and at slightly different instances in the time step, the Tioga Interface calls to fillpatch need to be made smarter to use the correct time in the algorithm. This hinges on the advance_states call that occurs at the beginning of the timestep. On top of that, the treatment of reading boundary plane data needs to be modified because of when pre_advance and exchange_solution calls happen from the overset solver.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Without this fix, the overset solver fails an assert when reading boundary planes in AMR-Wind.