Skip to content

Use packaging.versions insted of distutil.version, since the latter #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Mar 11, 2024

is deprecated in Python 3.1x ish.

@hategan hategan requested a review from andre-merzky March 11, 2024 02:20
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.69%. Comparing base (91ad420) to head (8ba9db5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage   74.69%   74.69%           
=======================================
  Files          94       94           
  Lines        3912     3912           
=======================================
  Hits         2922     2922           
  Misses        990      990           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this tedious thing!

StrictVersion now only mentioned in docs/development/tutorial_add_executor.rst (and docs/conf.py) and probably should be removed there, too?

@hategan
Copy link
Collaborator Author

hategan commented Mar 11, 2024

Thanks for doing this tedious thing!

Wasn't too bad.

StrictVersion now only mentioned in docs/development/tutorial_add_executor.rst (and docs/conf.py) and probably should be removed there, too?

Thank you for grepping for that and apologies that I didn't do it in the first place. Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants