Skip to content

There is no need to escape values here since the script generator alr… #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Oct 6, 2023

…eady does it.

Fixes #423

@hategan hategan requested a review from andre-merzky October 6, 2023 16:30
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79309dc) 73.93% compared to head (0d10772) 75.90%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   73.93%   75.90%   +1.96%     
==========================================
  Files          80       96      +16     
  Lines        3641     4515     +874     
==========================================
+ Hits         2692     3427     +735     
- Misses        949     1088     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@Andrew-S-Rosen
Copy link
Contributor

Andrew-S-Rosen commented Nov 14, 2023

Hi @andre-merzky, @hategan! Any chance we can get this merged into main soon? I think if the branch is updated to contain the changes in main, the tests should hopefully pass!

@hategan
Copy link
Collaborator Author

hategan commented Nov 14, 2023

Hi @andre-merzky, @hategan! Any chance we can get this merged into main soon? I think if the branch is updated to contain the changes in main, the tests should hopefully pass!

I'm not quite sure why this wasn't merged. I'll merge and make a new release.

@hategan hategan merged commit 4961f69 into main Nov 14, 2023
@hategan hategan deleted the fix_env_var_escaping branch November 14, 2023 05:54
@Andrew-S-Rosen
Copy link
Contributor

@hategan: Huge thanks!! That'll be a big help :)

@hategan
Copy link
Collaborator Author

hategan commented Nov 14, 2023

@hategan: Huge thanks!! That'll be a big help :)

Done. 0.9.3 should be out.

@Andrew-S-Rosen
Copy link
Contributor

Beautifulllll!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The environment kwarg in JobSpec gets the wrong number of quotation marks if there are spaces
3 participants